Skip to content

perf-tuning: add column-prune.md #3246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 17, 2020
Merged

perf-tuning: add column-prune.md #3246

merged 5 commits into from
Jul 17, 2020

Conversation

@toutdesuite
Copy link
Contributor

@toutdesuite toutdesuite commented Jul 13, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

add column-prune.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@toutdesuite
Copy link
Contributor Author

toutdesuite commented Jul 13, 2020

@lawyerphx PTAL, thanks

@toutdesuite toutdesuite requested review from TomShawn and yikeke and removed request for yikeke July 13, 2020 09:08
@toutdesuite toutdesuite added needs-cherry-pick-2.1 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jul 13, 2020
TomShawn
TomShawn reviewed Jul 13, 2020
View reviewed changes
TomShawn
TomShawn reviewed Jul 13, 2020
View reviewed changes
@toutdesuite @TomShawn
Apply suggestions from code review
b89bc5a 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@danmay319
Copy link
Contributor

danmay319 commented Jul 14, 2020

lgtm

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 14, 2020

@lawyerphx,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

TomShawn
TomShawn approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 17, 2020
@toutdesuite
Copy link
Contributor Author

toutdesuite commented Jul 17, 2020

/merge

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 17, 2020

@toutdesuite Oops! This PR requires at least 2 LGTMs to merge. The current number of LGTM is 1.

@toutdesuite toutdesuite merged commit 15bdb6a into pingcap:master Jul 17, 2020
@toutdesuite toutdesuite deleted the column-prune branch July 17, 2020 06:46
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 17, 2020
@toutdesuite @ti-srebot
cherry pick pingcap#3246 to release-2.1
834b0f1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 17, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 17, 2020

cherry pick to release-2.1 in PR #3316

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 17, 2020
@toutdesuite @ti-srebot
cherry pick pingcap#3246 to release-3.0
b2fb379 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 17, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 17, 2020

cherry pick to release-3.0 in PR #3317

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 17, 2020
@toutdesuite @ti-srebot
cherry pick pingcap#3246 to release-3.1
eac990c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 17, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 17, 2020

cherry pick to release-3.1 in PR #3318

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 17, 2020
@toutdesuite @ti-srebot
cherry pick pingcap#3246 to release-4.0
3d37802 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 17, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 17, 2020

cherry pick to release-4.0 in PR #3319

ti-srebot added a commit that referenced this pull request Jul 17, 2020
@ti-srebot
perf-tuning: add column-prune.md (#3246) (#3319)
2828693 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
toutdesuite added a commit that referenced this pull request Jul 20, 2020
@ti-srebot @toutdesuite
perf-tuning: add column-prune.md (#3246) (#3316)
b3228cb 
* cherry pick #3246 to release-2.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* resolve conflict

* another conflict

* Update column-pruning.md

Co-authored-by: toutdesuite <guizhiluo2014@163.com>
ti-srebot added a commit that referenced this pull request Jul 20, 2020
@ti-srebot
perf-tuning: add column-prune.md (#3246) (#3318)
e90d1d7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot added a commit that referenced this pull request Jul 20, 2020
@ti-srebot
perf-tuning: add column-prune.md (#3246) (#3317)
574e550 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@toutdesuite @danmay319 @ti-srebot @TomShawn