Skip to content

Update character-set-and-collation.md (#3402) #3540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2020
Merged

Update character-set-and-collation.md (#3402) #3540

merged 1 commit into from
Aug 4, 2020

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Aug 4, 2020

cherry-pick #3402 to release-4.0

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ireneontheway @ti-srebot
cherry pick pingcap#3402 to release-4.0
dcace5c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 4, 2020
Merged
9 tasks
@ti-srebot ti-srebot added requires-followup This PR requires a follow-up task after being merged. special-week PR from Document Special Week. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Aug 4, 2020
@ti-srebot ti-srebot requested review from a user, TomShawn, wjhuang2016 and yikeke August 4, 2020 09:09
ireneontheway
ireneontheway approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@ireneontheway ireneontheway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Aug 4, 2020

@ireneontheway,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@ireneontheway ireneontheway merged commit b317bc2 into pingcap:release-4.0 Aug 4, 2020
@ireneontheway ireneontheway deleted the release-4.0-52763cb7ad14 branch August 4, 2020 09:31
@TomShawn TomShawn removed the requires-followup This PR requires a follow-up task after being merged. label Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomShawn TomShawn Awaiting requested review from TomShawn

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@yikeke yikeke Awaiting requested review from yikeke

1 more reviewer

@ireneontheway ireneontheway ireneontheway approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ireneontheway ireneontheway

Labels

special-week PR from Document Special Week. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-srebot @ireneontheway @TomShawn