Skip to content

sql-statements: readability of commit/rollback#3664

Merged
lilin90 merged 10 commits intomasterfrom
unknown repository
Aug 17, 2020
Merged

sql-statements: readability of commit/rollback#3664
lilin90 merged 10 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 13, 2020

What is changed, added or deleted? (Required)

The rollback docs mentioned the completiontype, but didn't include the definition of it.

The mysql compatibility sections of commit and rollback talked about completiontype, but should have explained the syntax better, and the recommended alternative - since in both cases its pretty straight forward.

I have also mentioned savepoints, since it wasn't covered.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ghost ghost requested a review from kolbe August 13, 2020 17:57
kolbe
kolbe approved these changes Aug 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@kolbe kolbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 13, 2020

@kolbe,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@ghost ghost mentioned this pull request Aug 13, 2020
Merged
9 tasks
@TomShawn TomShawn added size/medium Changes of a medium size. translation/doing This PR's assignee is translating this PR. labels Aug 14, 2020
@TomShawn TomShawn self-assigned this Aug 14, 2020
@TomShawn TomShawn requested a review from lilin90 August 14, 2020 06:08
lilin90
lilin90 reviewed Aug 17, 2020
View reviewed changes
@lilin90 lilin90 added the status/require-change Needs the author to address comments. label Aug 17, 2020
Null not nil and others added 5 commits August 17, 2020 05:30
@lilin90
Update sql-statements/sql-statement-commit.md
2b13b37 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@lilin90
Update sql-statements/sql-statement-rollback.md
95297fe 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@lilin90
Update sql-statements/sql-statement-rollback.md
e886091 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@lilin90
Update sql-statements/sql-statement-start-transaction.md
cc32ad8 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@lilin90
Update sql-statements/sql-statement-start-transaction.md
e6132b0 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
lilin90
lilin90 approved these changes Aug 17, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2020
@lilin90 lilin90 merged commit 66535ca into pingcap:master Aug 17, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 17, 2020
@ti-srebot
cherry pick pingcap#3664 to release-4.0
0a04204 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 17, 2020
Merged
9 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 17, 2020

cherry pick to release-4.0 in PR #3686

ghost pushed a commit that referenced this pull request Aug 17, 2020
@ti-srebot
cherry pick #3664 to release-4.0 (#3686)
1eead7b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Null not nil <67764674+nullnotnil@users.noreply.github.com>
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Sep 9, 2020
@TomShawn TomShawn mentioned this pull request Sep 9, 2020
Merged
9 tasks
@ti-srebot ti-srebot mentioned this pull request Sep 21, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@TomShawn TomShawn

Labels

size/medium Changes of a medium size. status/LGT1 Indicates that a PR has LGTM 1. status/require-change Needs the author to address comments. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-srebot @kolbe @lilin90 @TomShawn