Skip to content

Conversation

@rkazak
Copy link

@rkazak rkazak commented Mar 27, 2021

If you want that code to be useable via the copy option, then we need to remove the '-> ' indicators.

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

If you want that code to be useable via the copy option, then we need to remove the '-> ' indicators.
@CLAassistant
Copy link

CLAassistant commented Mar 27, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Mar 27, 2021
@ti-chi-bot
Copy link
Member

Welcome @rkazak!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs. 😃

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 27, 2021
@morgo
Copy link
Contributor

morgo commented Mar 29, 2021

/LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 29, 2021
@TomShawn
Copy link
Contributor

/label needs-cherry-pick-5.0
/label needs-cherry-pick-master
/size small
/translation welcome

@ti-chi-bot ti-chi-bot added size/small Changes of a small size. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. needs-cherry-pick-5.0 needs-cherry-pick-master Should cherry pick this PR to master branch. and removed missing-translation-status This PR does not have translation status info. labels Mar 29, 2021
@TomShawn
Copy link
Contributor

/lgtm

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 42babb4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2021
@ti-chi-bot ti-chi-bot merged commit d405ae0 into pingcap:release-4.0 Mar 29, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 29, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5139

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 29, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to master in PR #5140

@Oreoxmt Oreoxmt self-assigned this Nov 4, 2022
@Oreoxmt Oreoxmt added translation/doing This PR's assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-cherry-pick-master Should cherry pick this PR to master branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants