Skip to content

add document about stale read transaction#5809

Merged
ti-chi-bot merged 7 commits intopingcap:masterfrom
CharLotteiu:add-stale-read
Jun 23, 2021
Merged

add document about stale read transaction#5809
ti-chi-bot merged 7 commits intopingcap:masterfrom
CharLotteiu:add-stale-read

Conversation

@CharLotteiu
Copy link
Copy Markdown
Contributor

@CharLotteiu CharLotteiu commented Jun 18, 2021 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

Add document about stale read transaction.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 18, 2021 07:46
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 18, 2021
@CharLotteiu CharLotteiu added needs-cherry-pick-release-5.0 status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.1 This PR/issue applies to TiDB v5.1. and removed missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 18, 2021
@CharLotteiu CharLotteiu requested review from Yisaer and nolouch June 18, 2021 07:47
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 18, 2021
TomShawn
TomShawn reviewed Jun 21, 2021
View reviewed changes
CharLotteiu and others added 5 commits June 22, 2021 11:41
@CharLotteiu @TomShawn
Apply suggestions from code review
c2722ce 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@CharLotteiu @TomShawn
Apply suggestions from code review
ffc2f0f 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@CharLotteiu
Update read-historical-data.md
167871e
@CharLotteiu
fix typo
ccd3b05
@CharLotteiu @TomShawn
Apply suggestions from code review
6797554 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn approved these changes Jun 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 22, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 23, 2021

@nolouch: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 23, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 23, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 23, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 23, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: e9eb8c4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2021
@ti-chi-bot ti-chi-bot merged commit cadb372 into pingcap:master Jun 23, 2021
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 23, 2021
@CharLotteiu @ti-chi-bot
This is an automated cherry-pick of pingcap#5809
2cac38a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 23, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 23, 2021

In response to a cherrypick label: new pull request created: #5829.

ti-chi-bot added a commit that referenced this pull request Jun 23, 2021
@ti-chi-bot
add document about stale read transaction (#5809) (#5829)
a9838d9
@CharLotteiu CharLotteiu deleted the add-stale-read branch July 9, 2021 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nolouch nolouch nolouch approved these changes

@Yisaer Yisaer Awaiting requested review from Yisaer

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.1 This PR/issue applies to TiDB v5.1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CharLotteiu @ti-chi-bot @TomShawn @nolouch @Yisaer