proto: add paging_size_bytes to coprocessor.Request#1448
Open
JmPotato wants to merge 1 commit intopingcap:masterfrom
Open
proto: add paging_size_bytes to coprocessor.Request#1448JmPotato wants to merge 1 commit intopingcap:masterfrom
JmPotato wants to merge 1 commit intopingcap:masterfrom
Conversation
Add a new uint64 field `paging_size_bytes` (field 16) to the coprocessor Request message. When set, TiKV will stop scanning when accumulated scanned bytes reach this limit, enabling byte-budget paging for finer-grained Resource Control. Signed-off-by: JmPotato <github@ipotato.me>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Add a new
paging_size_bytesfield (field 16,uint64) to thecoprocessor.Requestmessage.paging_size_bytesis 0, the feature is disabled (backward compatible).This enables byte-budget paging for Resource Control (RC), allowing TiDB to bound per-page resource consumption by byte size rather than only by row count.
Why is this needed?
In concurrent coprocessor workloads under Resource Control, row-count-based paging alone cannot prevent "token cliff" effects where multiple workers exhaust RU budgets simultaneously. A byte-based budget provides finer-grained control for RU pre-charging in PD's resource controller.
Related PRs