Skip to content

grafana: add max ping latency metric (#1070)#1072

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-8.5from
ti-chi-bot:cherry-pick-1070-to-release-8.5
Apr 7, 2026
Merged

grafana: add max ping latency metric (#1070)#1072
ti-chi-bot[bot] merged 1 commit intopingcap:release-8.5from
ti-chi-bot:cherry-pick-1070-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #1070

close: #1071

Summary

  • keep the existing Ping Latency series for raw probe duration
  • add a Max Ping Latency series using max_over_time on probe_duration_seconds over 1 minute for the selected PingJobHost
  • align the new series with the BLACKER_ping_latency_more_than_1s alert logic while preserving PingJobHost filtering

Validation

  • git diff --check
  • reviewed the updated Grafana panel JSON diff

Signed-off-by: yibin87 <huyibin@pingcap.com>
Copy link
Copy Markdown
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 7, 2026

@yibin87: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 7, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 7, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-07 07:01:07.101799539 +0000 UTC m=+853272.307159596: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot bot added the approved label Apr 7, 2026
@ti-chi-bot ti-chi-bot bot merged commit 074220d into pingcap:release-8.5 Apr 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants