web: 3072 fix TypeScript typings for popover portal, selector refs, and owner info#3080
Merged
sykp241095 merged 2 commits intoMay 6, 2026
Conversation
…ner info - replace deprecated/invalid Radix portal type with PopoverPortalProps - avoid cloneElement ref injection by passing ref via renderInput props contract - make OwnerInfo.avatar_url optional to match internal API response shape
|
@labeebahmad201 is attempting to deploy a commit to the DB9 AI Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
Hey @sykp241095, could you look into this & review the PR? Thanks. |
sykp241095
approved these changes
May 6, 2026
Member
sykp241095
left a comment
sykp241095
left a comment
There was a problem hiding this comment.
LGTM. Reviewed the TypeScript typing fixes for Radix popover portal props, RemoteSelector input refs, OwnerInfo.avatar_url, and useRef initialization. The remaining failing checks are Vercel authorization-only failures, so they are not blocking this change.
Member
|
Reviewed and merged. Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3072