Skip to content

fix sel field#1311

Merged
wjhuang2016 merged 3 commits intopingcap:masterfrom
wjhuang2016:test_set
Aug 19, 2021
Merged

fix sel field#1311
wjhuang2016 merged 3 commits intopingcap:masterfrom
wjhuang2016:test_set

Conversation

@wjhuang2016
Copy link
Member

What problem does this PR solve?

For pingcap/tidb#27320

What is changed and how it works?

Something is missing when refactoring.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
mysql> WITH RECURSIVE cte AS (SELECT 5 UNION SELECT @c:=@c+1 FROM cte WHERE @c<3) SELECT * FROM cte;
+---+
| 5 |
+---+
| 5 |
+---+
1 row in set (0.00 sec)
mysql> select 1  union select 2;
+---+
| 1 |
+---+
| 1 |
| 2 |
+---+
2 rows in set (0.00 sec)

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 18, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@wjhuang2016 wjhuang2016 added the needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 label Aug 18, 2021
@ti-chi-bot
Copy link
Member

@lzmhhh123: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016 wjhuang2016 merged commit 7460643 into pingcap:master Aug 19, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1315.

wjhuang2016 pushed a commit that referenced this pull request Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 status/LGT1 LGT1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants