Skip to content

fix select field again#1317

Merged
wjhuang2016 merged 7 commits intopingcap:masterfrom
wjhuang2016:fix_field_again
Aug 19, 2021
Merged

fix select field again#1317
wjhuang2016 merged 7 commits intopingcap:masterfrom
wjhuang2016:fix_field_again

Conversation

@wjhuang2016
Copy link
Member

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot
Copy link
Member

@lzmhhh123: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@wjhuang2016 wjhuang2016 added the needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 label Aug 19, 2021
@wjhuang2016 wjhuang2016 merged commit 48d84c1 into pingcap:master Aug 19, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1318.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants