Skip to content

Add bytebase/bytebase as a user#1360

Merged
xhebox merged 1 commit intopingcap:masterfrom
tianzhou:patch-1
Jan 18, 2022
Merged

Add bytebase/bytebase as a user#1360
xhebox merged 1 commit intopingcap:masterfrom
tianzhou:patch-1

Conversation

@tianzhou
Copy link
Copy Markdown
Contributor

@tianzhou tianzhou commented Oct 5, 2021

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 5, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kennytm
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 5, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot
Copy link
Copy Markdown
Member

Welcome @tianzhou!

It looks like this is your first PR to pingcap/parser 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/parser. 😃

@ti-chi-bot ti-chi-bot added the status/LGT1 LGT1 label Oct 5, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Oct 20, 2021
@tangenta
Copy link
Copy Markdown
Contributor

@tianzhou Could you sign the CLA so that we can merge your PR?

https://cla-assistant.io/pingcap/parser?pullRequest=1360

@tisonkun
Copy link
Copy Markdown
Contributor

Thank you! @kennytm @tangenta as parser repo merged into tidb repo, shall we update the README there also?

@tianzhou
Copy link
Copy Markdown
Contributor Author

Ping?

Copy link
Copy Markdown
Contributor

@sunxiaoguang sunxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

@sunxiaoguang: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xhebox xhebox merged commit 6a854bc into pingcap:master Jan 18, 2022
@tisonkun
Copy link
Copy Markdown
Contributor

@xhebox IIUC this repo is merged into pingcap/tidb so that we shouldn't merge it here but create a duplicate on pingcap/tidb?

@xhebox
Copy link
Copy Markdown
Contributor

xhebox commented Jan 18, 2022

@xhebox IIUC this repo is merged into pingcap/tidb so that we shouldn't merge it here but create a duplicate on pingcap/tidb?

Yeah, I will do that later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants