Skip to content

terror: add error class ClassUtil#628

Merged
kennytm merged 2 commits intopingcap:masterfrom
imtbkcat:addClassUtil
Nov 8, 2019
Merged

terror: add error class ClassUtil#628
kennytm merged 2 commits intopingcap:masterfrom
imtbkcat:addClassUtil

Conversation

@imtbkcat
Copy link
Copy Markdown

@imtbkcat imtbkcat commented Nov 8, 2019

What problem does this PR solve?

Errors in TiDB util package use ClassExecutor as error code class, but they can not init their error code in executor package. So all errors in util package can only use default error code.

What is changed and how it works?

Add error class ClassUtil for util package.

Check List

Tests

  • Unit test (at TiDB repo)

Code changes

  • Has exported variable/fields change

Side effects

  • No

@imtbkcat imtbkcat requested review from a team and jackysp November 8, 2019 08:01
@ghost ghost requested review from kennytm and removed request for a team November 8, 2019 08:01
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b1eb5fc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #628   +/-   ##
=========================================
  Coverage          ?   79.78%           
=========================================
  Files             ?       32           
  Lines             ?    12582           
  Branches          ?        0           
=========================================
  Hits              ?    10038           
  Misses            ?     1948           
  Partials          ?      596
Impacted Files Coverage Δ
terror/terror.go 74.19% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1eb5fc...bedbb91. Read the comment docs.

Copy link
Copy Markdown
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta added the status/LGT1 LGT1 label Nov 8, 2019
Copy link
Copy Markdown
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Nov 8, 2019
@kennytm kennytm merged commit 3d7cdc1 into pingcap:master Nov 8, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants