Skip to content

parser : add invalid auto increment and offset error.#707

Merged
tangenta merged 3 commits intopingcap:masterfrom
AilinKid:increment_offset
Jan 2, 2020
Merged

parser : add invalid auto increment and offset error.#707
tangenta merged 3 commits intopingcap:masterfrom
AilinKid:increment_offset

Conversation

@AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Jan 2, 2020

What problem does this PR solve?

add errcode and errname for variable auto_increment_increment and auto_increment_offset.
Related TiDB PR #14301

What is changed and how it works?

Check List

Tests

  • Integration test

@AilinKid AilinKid requested a review from a team January 2, 2020 05:11
@ghost ghost requested review from tangenta and removed request for a team January 2, 2020 05:11
@AilinKid AilinKid requested a review from a team January 2, 2020 05:12
@ghost ghost removed their request for review January 2, 2020 05:12
@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #707 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #707   +/-   ##
=======================================
  Coverage   77.98%   77.98%           
=======================================
  Files          38       38           
  Lines       14020    14020           
=======================================
  Hits        10933    10933           
  Misses       2435     2435           
  Partials      652      652

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants