parser: introduce a new privilege for the set config statement#835
Merged
tiancaiamao merged 2 commits intopingcap:masterfrom Apr 27, 2020
Merged
parser: introduce a new privilege for the set config statement#835tiancaiamao merged 2 commits intopingcap:masterfrom
set config statement#835tiancaiamao merged 2 commits intopingcap:masterfrom
Conversation
ghost
removed their request for review
Codecov Report
@@ Coverage Diff @@
## master #835 +/- ##
=======================================
Coverage 78.35% 78.36%
=======================================
Files 40 40
Lines 14755 14757 +2
=======================================
+ Hits 11562 11564 +2
Misses 2512 2512
Partials 681 681 |
Contributor
Author
|
/rebuild |
Contributor
Author
|
/run-all-tests |
Collaborator
|
The build-integration test seems to be failed, is there a corresponding PR in TiDB? |
Contributor
Author
Yes, it's pingcap/tidb#16847. |
Collaborator
|
LGTM |
tiancaiamao
approved these changes
Apr 27, 2020
qw4990
added a commit
to qw4990/parser
that referenced
this pull request
May 21, 2020
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Close #826.
After #768, we can use
set configon TiDB to update configs of TiKV/PD.Now the privilege of this statement is
PrivSuper, which is not appropriate.We should introduce a new privilege for it.
What is changed and how it works?
Introduce a new privilege
CONFIG_PRIV.Check List
Tests