Unreserved 8 keywords by kennytm · Pull Request #851 · pingcap/parser

kennytm · 2020-05-10T20:27:50Z

What problem does this PR solve?

What is changed and how it works?

Unreserved the following 8 keywords:

chain
error
general
nvarchar
pack_keys
parser
shard_row_id_bits
pre_split_regions

And added a manually executed test case to ensure the list of reserved keywords mostly match that of MySQL. The only discrepancy currently are:

current_role — reserved in TiDB, not reserved in MySQL (introduced by parser, ast: add SET ROLE support #228, caused significant reduce/reduce conflict when unreserved, cc @imtbkcat)
function — reserved since MySQL 8.0.1, not reserved in TiDB
separator — reserved in MySQL (why?), not reserved in TiDB

Check List

Tests

Unit test

Code changes

Side effects

Related changes

Need to cherry-pick to the release branch
- Affects all TiDB versions.

Release note

CHAIN, ERROR, GENERAL, NVARCHAR, PACK_KEYS, PARSER, SHARD_ROW_ID_BITS and PRE_SPLIT_REGIONS are no longer treated as reserved words.

codecov · 2020-05-10T20:30:04Z

Codecov Report

Merging #851 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #851   +/-   ##
=======================================
  Coverage   78.28%   78.28%           
=======================================
  Files          40       40           
  Lines       14667    14667           
=======================================
  Hits        11482    11482           
  Misses       2502     2502           
  Partials      683      683

tangenta

LGTM

tiancaiamao · 2020-05-12T03:31:57Z

shard_row_id_bits and pre_split_regions, should them be unreserved-keyword or non-keyword?

kennytm · 2020-05-12T04:43:36Z

hmm what's the difference between UnreservedKeyword, NotKeyword and TiDBKeyword?

tiancaiamao · 2020-05-12T05:48:30Z

hmm what's the difference between UnreservedKeyword, NotKeyword and TiDBKeyword?

I'm not sure there is any difference between NonKeyword and UnreservedKeyword.
NonKeyword is solely an identifier, whereas UnreservedKeyword can alse be used just like an identifier (no need to warp with `), so I can't tell apart them.

https://dev.mysql.com/doc/refman/5.7/en/keywords.html

If you are not sure as well, I think we can merge this change. Anyway, nobody knows or cares about it. @kennytm

tiancaiamao · 2020-05-12T05:48:38Z

LGTM

kennytm · 2020-05-12T06:07:08Z

/run-cherry-picker

sre-bot · 2020-05-12T06:07:24Z

cherry pick to release-3.0 failed

sre-bot · 2020-05-12T06:08:00Z

cherry pick to release-3.0 failed

sre-bot · 2020-05-12T06:08:36Z

cherry pick to release-3.1 failed

sre-bot · 2020-05-12T06:09:14Z

cherry pick to release-3.1 failed

sre-bot · 2020-05-12T06:09:55Z

cherry pick to release-4.0 failed

sre-bot · 2020-05-12T06:10:34Z

cherry pick to release-4.0 failed

kennytm · 2020-05-12T06:12:07Z

okay.

* parser.y: unreserve 8 keywords * consistent_test: added an optional test to check against MySQL keywords

* parser.y: unreserve 8 keywords * consistent_test: added an optional test to check against MySQL keywords Co-authored-by: kennytm <kennytm@gmail.com>

lysu · 2020-07-15T07:12:37Z

hi @kennytm could please help cherry-pick this to 3.0 and 3.1, some customers meet this problem too in 3.0, thanks~

* parser.y: unreserve 8 keywords * consistent_test: added an optional test to check against MySQL keywords

kennytm · 2020-07-15T09:28:24Z

@lysu #928, #929.

* parser.y: unreserve 8 keywords * consistent_test: added an optional test to check against MySQL keywords

kennytm added 2 commits May 11, 2020 04:15

parser.y: unreserve 8 keywords

0fd10f6

consistent_test: added an optional test to check against MySQL keywords

0bba6c2

kennytm added type/bug-fix fix bug status/PTAL needs-cherry-pick-release-3.1 needs-cherry-pick-release-3.0 needs-cherry-pick-release-4.0 labels May 10, 2020

kennytm requested review from a team, tangenta and tiancaiamao May 10, 2020 20:27

ghost removed their request for review May 10, 2020 20:27

tangenta reviewed May 11, 2020

View reviewed changes

tangenta added the status/LGT1 LGT1 label May 11, 2020

tiancaiamao added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels May 12, 2020

tiancaiamao approved these changes May 12, 2020

View reviewed changes

Merge branch 'master' into kennytm/error-is-not-a-keyword

5890b78

kennytm merged commit fa89057 into master May 12, 2020

kennytm deleted the kennytm/error-is-not-a-keyword branch May 12, 2020 06:06

tangenta pushed a commit to tangenta/parser that referenced this pull request Jun 5, 2020

Unreserved 8 keywords (pingcap#851)

9522ea1

* parser.y: unreserve 8 keywords * consistent_test: added an optional test to check against MySQL keywords

tangenta pushed a commit to tangenta/parser that referenced this pull request Jun 5, 2020

Unreserved 8 keywords (pingcap#851)

d77fa40

* parser.y: unreserve 8 keywords * consistent_test: added an optional test to check against MySQL keywords

tangenta added a commit that referenced this pull request Jun 9, 2020

Unreserved 8 keywords (#851) (#885)

bfe54cd

* parser.y: unreserve 8 keywords * consistent_test: added an optional test to check against MySQL keywords Co-authored-by: kennytm <kennytm@gmail.com>

kennytm added a commit that referenced this pull request Jul 15, 2020

Unreserved 8 keywords (#851)

3e80adb

* parser.y: unreserve 8 keywords * consistent_test: added an optional test to check against MySQL keywords

kennytm mentioned this pull request Jul 15, 2020

Unreserved 5 keywords (#851) #928

Merged

kennytm added a commit that referenced this pull request Jul 15, 2020

Unreserved 8 keywords (#851)

392b3c1

* parser.y: unreserve 8 keywords * consistent_test: added an optional test to check against MySQL keywords

kennytm mentioned this pull request Jul 15, 2020

Unreserved 5 keywords (#851) #929

Merged

kennytm added a commit that referenced this pull request Jul 16, 2020

Unreserved 8 keywords (#851) (#928)

eeeb01d

* parser.y: unreserve 8 keywords * consistent_test: added an optional test to check against MySQL keywords

kennytm added a commit that referenced this pull request Jul 16, 2020

Unreserved 8 keywords (#851) (#929)

1f6b47b

* parser.y: unreserve 8 keywords * consistent_test: added an optional test to check against MySQL keywords

lysu mentioned this pull request Mar 17, 2021

downgrade mysql driver version #1193

Merged

tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021

Unreserved 8 keywords (pingcap#851)

db9b353

* parser.y: unreserve 8 keywords * consistent_test: added an optional test to check against MySQL keywords

Conversation

kennytm commented May 10, 2020

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

codecov bot commented May 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tangenta left a comment

Choose a reason for hiding this comment

Uh oh!

tiancaiamao commented May 12, 2020

Uh oh!

kennytm commented May 12, 2020

Uh oh!

tiancaiamao commented May 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tiancaiamao commented May 12, 2020

Uh oh!

kennytm commented May 12, 2020

Uh oh!

sre-bot commented May 12, 2020

Uh oh!

sre-bot commented May 12, 2020

Uh oh!

sre-bot commented May 12, 2020

Uh oh!

sre-bot commented May 12, 2020

Uh oh!

sre-bot commented May 12, 2020

Uh oh!

sre-bot commented May 12, 2020

Uh oh!

kennytm commented May 12, 2020

Uh oh!

lysu commented Jul 15, 2020

Uh oh!

kennytm commented Jul 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented May 10, 2020 •

edited

Loading

tiancaiamao commented May 12, 2020 •

edited

Loading