feat: add use_database() / current_database() API and execute tests in concurrent#154
Merged
feat: add use_database() / current_database() API and execute tests in concurrent#154
Conversation
Signed-off-by: Wish <breezewish@outlook.com>
Mini256
reviewed
Jul 17, 2025
There was a problem hiding this comment.
Bug: Temporary Client Ownership Causes Resource Conflicts
In TiDBClient.use_database(), a temporary TiDBClient instance (new_client) is created solely to extract its _db_engine and other attributes. This leads to unnecessary object instantiation and a resource ownership issue: new_client retains references to the engine now owned by self. If new_client were to be disposed, it could prematurely dispose of the engine currently in use by the main client, leading to resource conflicts.
pytidb/client.py#L165-L179
Lines 165 to 179 in 09fd405
Was this report helpful? Give feedback by reacting with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New:
The verbose tests and doc comments are written by AI.
Note: the current implementation is basic, not good, see TODO in the code for the desired state.