docs: use tidb_client.db_engine in README example (fixes #193)#195
Closed
haseebpvt wants to merge 1 commit intopingcap:mainfrom
Closed
docs: use tidb_client.db_engine in README example (fixes #193)#195haseebpvt wants to merge 1 commit intopingcap:mainfrom
haseebpvt wants to merge 1 commit intopingcap:mainfrom
Conversation
f7d8658 to
e8ba100
Compare
e8ba100 to
ad7aa1f
Compare
Contributor
Author
|
Somehow, even after adding the signing keys, my commits are still not showing the “Verified” badge. I’ll try one last time by closing this PR and reopening it from a fresh branch, since I’m not sure if the issue is related to all commits needing to be signed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #193
The README previously used an undefined
enginevariable in the"Join Structured and Unstructured Data" example.
This change updates the code example to use
tidb_client.db_engine,making the example explicit and reducing confusion for new users.
Example after fix: