Skip to content

chore: aiohttp to 3.11.18 to drop the warning#81

Merged
Mini256 merged 1 commit intopingcap:mainfrom
yihong0618:hy/chore_aiohttp
Jun 3, 2025
Merged

chore: aiohttp to 3.11.18 to drop the warning#81
Mini256 merged 1 commit intopingcap:mainfrom
yihong0618:hy/chore_aiohttp

Conversation

@yihong0618
Copy link
Copy Markdown
Contributor

3.11.14 has been yanked due to a regression. Upgrade to latest.
https://pypi.org/project/aiohttp/#history
aio-libs/aiohttp#10617

@sre-bot
Copy link
Copy Markdown

sre-bot commented Jun 3, 2025

CLA assistant check
All committers have signed the CLA.

pyproject.toml Outdated
"sqlmodel>=0.0.14",
"tidb-vector>=0.0.14",
"pymysql>=1.1.1",
"aiohttp==3.11.18",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aiohttp is a dependency introduced by the optional dependency litellm, and we shouldn't fix its version in the required dependencies. Maybe we just need to update the uv.lock file

https://github.com/BerriAI/litellm/blob/d408814978b2064c44f65cf1e02c169360c32785/pyproject.toml#L31

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes also found that, will take a try

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Copy link
Copy Markdown
Member

@Mini256 Mini256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mini256 Mini256 merged commit a52b410 into pingcap:main Jun 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants