cloudstorage: fix a bug that may cause changefeed getting stuck

[asddongmen]

What problem does this PR solve?

Issue Number: close #1239

What is changed and how it works?

Check List

Tests

• Unit test

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

[Copilot]

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

cmd/storage-consumer/main.go:182

• Inconsistent use of external storage instantiation functions detected. Ensure that a single API (preferably the timeout-aware version) is used across components to maintain consistent behavior.

storage, err := putil.GetExternalStorageFromURI(ctx, upstreamURIStr)

[Copilot]

This test uses GetExternalStorageFromURI while other parts of the system use a timeout-aware function. Standardize the external storage creation method to ensure uniform behavior.

Suggested change

	storage, err := putil.GetExternalStorageFromURI(ctx, sinkURI.String())
	timeoutCtx, cancel := context.WithTimeout(ctx, 30*time.Second)
	defer cancel()
	storage, err := putil.GetExternalStorageFromURIWithTimeout(timeoutCtx, sinkURI.String())

[wk989898]

Should we use GetExternalStorageWithDefaultTimeout anywhere without exporting GetExternalStorageFromURI?

[asddongmen]

Should we use GetExternalStorageWithDefaultTimeout anywhere without exporting GetExternalStorageFromURI?

Good idea.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wk989898

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [wk989898]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2025-04-17 07:34:18.962578067 +0000 UTC m=+2932952.646814165: ☑️ agreed by wk989898.

[asddongmen]

/retest

[ti-chi-bot]

@asddongmen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cdc-pulsar-integration-light	12372b6	link	false	/test pull-cdc-pulsar-integration-light
pull-cdc-kafka-integration-light	12372b6	link	false	/test pull-cdc-kafka-integration-light

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.