log: add some debug log#2058
Conversation
ti-chi-bot
Bot
added
do-not-merge/needs-linked-issue
release-note
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @hongyunyan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on enhancing the testing of failover scenarios within the CI pipeline. It adjusts the integration test configuration to heavily emphasize failover tests and includes a minor logging improvement to aid in debugging event handling.
Highlights
- Enhanced Debug Logging: Added
eventsandevent lento a debug log indownstreamadapter/eventcollector/helper.goto provide more context when handling events. - Integration Test Configuration Update: Modified
tests/integration_tests/run_heavy_it_in_ci.shto focus themysql_groupsin CI pipelines almost exclusively onfail_overtests, replacing a diverse set of tests with repeatedfail_overentries.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
ti-chi-bot
Bot
added
the
size/M
There was a problem hiding this comment.
Code Review
This pull request appears to be for temporary testing of failover scenarios. I've identified two main issues. First, a new debug log statement is potentially very expensive and could impact performance. Second, the integration test configuration has been modified to run only fail_over tests, disabling many other important checks. These changes are not suitable for a production branch and should be addressed before merging.
| mysql_groups=( | ||
| # G00 | ||
| 'generate_column many_pk_or_uk multi_source' | ||
| # G01 | ||
| 'api_v2 ddl_for_split_tables_with_random_move_table' | ||
| # G02 | ||
| 'availability ddl_for_split_tables_with_failover' | ||
| # G03 | ||
| 'cdc move_table' | ||
| 'fail_over fail_over fail_over' | ||
| # G13 | ||
| 'fail_over fail_over fail_over' | ||
| # G14 | ||
| 'fail_over fail_over fail_over' | ||
| # G15 | ||
| 'fail_over fail_over fail_over' | ||
| # G04 | ||
| 'syncpoint syncpoint_check_ts ' | ||
| # G05 | ||
| 'ddl_for_split_tables_with_merge_and_split' | ||
| # G06 | ||
| 'ddl_for_split_tables_with_random_merge_and_split' | ||
| # G07 | ||
| # 'consistent_partition_table consistent_replicate_gbk consistent_replicate_ddl' | ||
| '' | ||
| 'fail_over fail_over fail_over' | ||
| # G13 | ||
| 'fail_over fail_over fail_over' | ||
| # G14 | ||
| 'fail_over fail_over fail_over' | ||
| # G15 | ||
| 'fail_over fail_over fail_over' | ||
| # G08 | ||
| 'default_value http_proxies bank ddl_for_split_tables_random_schedule' | ||
| # G09 | ||
| 'resolve_lock merge_table drop_many_tables' | ||
| # G10 | ||
| # 'consistent_replicate_nfs consistent_replicate_storage_file consistent_replicate_storage_file_large_value consistent_replicate_storage_s3' | ||
| '' | ||
| # G11 | ||
| 'ddl_reentrant force_replicate_table' | ||
| 'fail_over fail_over fail_over' | ||
| # G13 | ||
| 'fail_over fail_over fail_over' | ||
| # G14 | ||
| 'fail_over fail_over fail_over' | ||
| # G15 | ||
| 'fail_over fail_over fail_over' | ||
| # G12 | ||
| 'tidb_mysql_test ddl_with_random_move_table' | ||
| 'fail_over fail_over fail_over' | ||
| # G13 | ||
| 'fail_over region_merge' | ||
| 'fail_over fail_over fail_over' | ||
| # G14 | ||
| 'fail_over_ddl_mix' | ||
| 'fail_over fail_over fail_over' | ||
| # G15 | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| 'fail_over fail_over fail_over' | ||
| ) |
There was a problem hiding this comment.
These changes appear to be for temporary testing of the fail_over case, as they replace all other MySQL integration tests and run the fail_over test repeatedly. This is useful for focused testing but must be reverted before merging to the main branch to ensure all integration tests are run in CI. Disabling a large portion of the test suite is a critical issue for the master branch.
Additionally, the group comments (e.g., # G13, # G14) are now incorrect and repeated, which can cause confusion.
| // Invariant: at any times, we can receive events from at most two event service, and one of them must be local event service. | ||
| func (h *EventsHandler) Handle(stat *dispatcherStat, events ...dispatcher.DispatcherEvent) bool { | ||
| log.Debug("handle events", zap.Any("dispatcher", stat.target.GetId())) | ||
| log.Debug("handle events", zap.Any("dispatcher", stat.target.GetId()), zap.Any("events", events), zap.Any("event len", len(events))) |
There was a problem hiding this comment.
Logging the entire events slice with zap.Any("events", events) can be very expensive and produce excessively large log messages, especially since a batch can contain up to 4096 events. This can negatively impact performance, even for a debug log. It's better to log only a summary or key information. Since you're already logging the length, consider removing the logging of the full slice and using zap.Int for the length for better type safety and performance.
| log.Debug("handle events", zap.Any("dispatcher", stat.target.GetId()), zap.Any("events", events), zap.Any("event len", len(events))) | |
| log.Debug("handle events", zap.Any("dispatcher", stat.target.GetId()), zap.Int("event len", len(events))) |
|
/test pull-cdc-mysql-integration-heavy |
3 similar comments
|
/test pull-cdc-mysql-integration-heavy |
|
/test pull-cdc-mysql-integration-heavy |
|
/test pull-cdc-mysql-integration-heavy |
ti-chi-bot
Bot
added
do-not-merge/needs-triage-completed
and removed
do-not-merge/needs-linked-issue
labels
ti-chi-bot
Bot
added
size/XS
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
2 participants
What problem does this PR solve?
Issue Number: ref #2055
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note