Skip to content

Conversation

@wk989898
Copy link
Collaborator

@wk989898 wk989898 commented Dec 9, 2025

What problem does this PR solve?

Issue Number: close #3557 ref #1644

What is changed and how it works?

  • Changefeed Resumption Logic: Modified the ResumeChangefeed function in etcd_backend.go to explicitly set the Progress field of the changefeed status to config.ProgressNone when a changefeed is resumed. This ensures that progress tracking is reset or initialized correctly upon resumption.
  • Stop Changefeed Operator: Wait for the operator to finish after executing api call

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 9, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @wk989898, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the state management of changefeeds within the TiCDC coordinator. Specifically, it addresses how a changefeed's progress is handled when it transitions from a paused to a running state, aiming to ensure a clean and accurate restart of progress tracking upon resumption.

Highlights

  • Changefeed Resumption Logic: Modified the ResumeChangefeed function in etcd_backend.go to explicitly set the Progress field of the changefeed status to config.ProgressNone when a changefeed is resumed. This ensures that progress tracking is reset or initialized correctly upon resumption.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 9, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request modifies the ResumeChangefeed function in coordinator/changefeed/etcd_backend.go to set the status.Progress field to config.ProgressNone when a changefeed is resumed. There are no review comments provided for this change.

@wk989898
Copy link
Collaborator Author

wk989898 commented Dec 9, 2025

/test all

@wk989898 wk989898 changed the title [WIP] coordinator: fix incorrect changefeed status when resuming changefeed Dec 10, 2025
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 10, 2025
@wk989898 wk989898 marked this pull request as ready for review December 10, 2025 05:38
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2025
@tenfyzhong
Copy link
Collaborator

/retest

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 10, 2025
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2025
@wk989898
Copy link
Collaborator Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 16, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 16, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 16, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-16 03:27:52.689013595 +0000 UTC m=+1530017.502791167: ☑️ agreed by hongyunyan.
  • 2025-12-16 03:28:47.642840209 +0000 UTC m=+1530072.456617782: ☑️ agreed by lidezhu.

@wk989898
Copy link
Collaborator Author

/retest

@wk989898
Copy link
Collaborator Author

/test pull-cdc-kafka-integration-heavy

@ti-chi-bot ti-chi-bot bot merged commit d286bf9 into master Dec 16, 2025
19 checks passed
@ti-chi-bot ti-chi-bot bot deleted the wk989898-patch-3 branch December 16, 2025 12:47
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 16, 2025

@wk989898: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-mysql-integration-heavy 2d7de6a link unknown /test pull-cdc-mysql-integration-heavy

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dispatcher can't created after pause/resume changefeed

5 participants