-
Notifications
You must be signed in to change notification settings - Fork 33
feat(dashboard): support TiDB Dashboard shows ticdc instance info #3933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(dashboard): support TiDB Dashboard shows ticdc instance info #3933
Conversation
Summary of ChangesHello @wlwilliamx, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the TiCDC API by adding a new endpoint that provides access to the instance's global configuration. This feature is crucial for integrating TiCDC with the TiDB Dashboard, allowing users to easily view and monitor the configuration of their TiCDC deployments directly from the dashboard. The change improves the overall manageability and transparency of TiCDC instances. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new API endpoint /config to expose the TiCDC server configuration, which is intended for use by the TiDB Dashboard. The implementation is straightforward and includes a new unit test for the endpoint.
My main concern is a critical security vulnerability. The new endpoint exposes the entire server configuration, including potentially sensitive security credentials, without authentication. I've provided a suggestion to mitigate this by masking the sensitive data before returning it.
Additionally, I've recommended enhancing the new unit test to verify that sensitive information is indeed stripped from the response, preventing future regressions.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lidezhu, wk989898 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
/unhold |
|
/retest |
7 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
What problem does this PR solve?
Issue Number: close #2128
What is changed and how it works?
Support TiDB Dashboard query ticdc config and shows ticdc instance info.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
None
Do you need to update user documentation, design documentation or monitoring documentation?
None
Release note