tests: disable same_upstream_downstream in release-8.5 CI

[wlwilliamx]

What problem does this PR solve?

Issue Number: close #4422

What is changed and how it works?

Temporarily disable the same_upstream_downstream integration test in release-8.5 CI, because TiDB 8.5.x (release-8.5 line) does not write cluster_id into mysql.tidb (pingcap/tidb#59511 was not cherry-picked to release-8.5). Re-enable it after TiDB release-8.5 has mysql.tidb.cluster_id.

Check List

Tests

• Manual test

Manual test steps:

• bash -n tests/integration_tests/run_light_it_in_ci.sh

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

None

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 51e4ed3f-fa6a-4927-bdd3-1a2121939b33

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a temporary fix for a failing CI pipeline on the release-8.5 branch. It addresses an issue where an integration test, same_upstream_downstream, was failing due to a missing cluster_id field in TiDB 8.5.x. By disabling this specific test, the CI can pass, ensuring the stability of the release-8.5 branch's automated checks until the underlying TiDB dependency is resolved.

Highlights

• CI Test Disablement: Temporarily disabled the same_upstream_downstream integration test in the release-8.5 CI pipeline. This action was taken because TiDB 8.5.x currently does not write cluster_id into mysql.tidb, which is a prerequisite for this test. The test will be re-enabled once the cluster_id functionality is backported to TiDB 8.5.x.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• tests/integration_tests/run_light_it_in_ci.sh
  • Removed the same_upstream_downstream test from the list of integration tests.
  • Added comments explaining the temporary disablement and the conditions for re-enabling the test.

Activity

• No activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses the immediate issue by temporarily disabling the same_upstream_downstream integration test in the release-8.5 CI. The detailed explanation provided in the code comment is highly beneficial for future maintainability, clearly stating the reason for the disablement and the conditions for re-enabling the test. This approach ensures that the CI remains functional while awaiting the necessary upstream changes.

[gemini-code-assist]

To enhance traceability, consider adding a reference to the current pull request's issue number (#4422) within the comment. This would make it easier for future developers to find the context and discussion surrounding this temporary disablement directly from the code.

Suggested change

	# NOTE: same_upstream_downstream is temporarily disabled on release-8.5 CI because TiDB 8.5.x
	# NOTE: same_upstream_downstream is temporarily disabled (ref #4422) on release-8.5 CI because TiDB 8.5.x

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flowbehappy, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [flowbehappy,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2026-03-11 14:58:58.21491574 +0000 UTC m=+448569.726973401: ☑️ agreed by hongyunyan.
• 2026-03-12 02:57:31.88246731 +0000 UTC m=+491683.394524971: ☑️ agreed by flowbehappy.

[ti-chi-bot]

@wlwilliamx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-unit-test	ce0628d	link	unknown	/test pull-unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.