Skip to content

tests: remove get_format integration checks #4668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ti-chi-bot merged 2 commits into from
Apr 1, 2026
Merged

tests: remove get_format integration checks #4668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a96ef2f
test(date_formats): Remove get_format function tests
tenfyzhong Apr 1, 2026
8d8e443
fix(test): remove test case for Bug#58005
tenfyzhong Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions tests/integration_tests/tidb_mysql_test/r/date_formats.result
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,21 +312,6 @@ date format con
2003-01-02 10:11:12 %Y-%m-%d %h:%i:%S 2003-01-02 10:11:12.000000
03-01-02 10:11:12 PM %Y-%m-%d %h:%i:%S %p 2003-01-02 22:11:12.000000
SET sql_mode = default;
select get_format(DATE, 'USA') as a;
a
%m.%d.%Y
select get_format(TIME, 'internal') as a;
a
%H%i%s
select get_format(DATETIME, 'eur') as a;
a
%Y-%m-%d %H.%i.%s
select get_format(TIMESTAMP, 'eur') as a;
a
%Y-%m-%d %H.%i.%s
select get_format(DATE, 'TEST') as a;
a

select str_to_date('15-01-2001 12:59:59', GET_FORMAT(DATE,'USA'));
str_to_date('15-01-2001 12:59:59', GET_FORMAT(DATE,'USA'))
NULL
Expand Down Expand Up @@ -466,11 +451,6 @@ Thursday 01 January 2009
#
# Bug#58005 utf8 + get_format causes failed assertion: !str || str != Ptr'
#
SET NAMES utf8;
SELECT LEAST('%', GET_FORMAT(datetime, 'eur'), CAST(GET_FORMAT(datetime, 'eur') AS CHAR(65535)));
LEAST('%', GET_FORMAT(datetime, 'eur'), CAST(GET_FORMAT(datetime, 'eur') AS CHAR(65535)))
%
SET NAMES latin1;
#
# End of 5.1 tests
#
Expand Down
8 changes: 0 additions & 8 deletions tests/integration_tests/tidb_mysql_test/t/date_formats.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,6 @@ select date,format,concat(str_to_date(date, format),'') as con from t1;
# Test of get_format
#
SET sql_mode = default;
select get_format(DATE, 'USA') as a;
select get_format(TIME, 'internal') as a;
select get_format(DATETIME, 'eur') as a;
select get_format(TIMESTAMP, 'eur') as a;
select get_format(DATE, 'TEST') as a;
select str_to_date('15-01-2001 12:59:59', GET_FORMAT(DATE,'USA'));
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The PR aims to remove get_format assertions because they are unstable across environments. However, this line still uses GET_FORMAT(DATE, 'USA') as an argument to str_to_date. If the output of GET_FORMAT changes, the result of this query (currently NULL) might also change, leading to continued instability. To fully achieve the goal of environment-independent tests, consider replacing GET_FORMAT(DATE, 'USA') with a literal format string like '%m.%d.%Y'.

select str_to_date('15-01-2001 12:59:59', '%m.%d.%Y');



Expand Down Expand Up @@ -241,9 +236,6 @@ SELECT DATE_FORMAT("2009-01-01",'%W %d %M %Y') as valid_date;
--echo #
--echo # Bug#58005 utf8 + get_format causes failed assertion: !str || str != Ptr'
--echo #
SET NAMES utf8;
SELECT LEAST('%', GET_FORMAT(datetime, 'eur'), CAST(GET_FORMAT(datetime, 'eur') AS CHAR(65535)));
SET NAMES latin1;

--echo #
--echo # End of 5.1 tests
Expand Down
Loading