Skip to content

chore: update Go to 1.25.10#5192

Open
lybcodes wants to merge 2 commits into
pingcap:release-8.5from
lybcodes:chore/update-go-1.25.10-release-8.5
Open

chore: update Go to 1.25.10#5192
lybcodes wants to merge 2 commits into
pingcap:release-8.5from
lybcodes:chore/update-go-1.25.10-release-8.5

Conversation

@lybcodes
Copy link
Copy Markdown

@lybcodes lybcodes commented Jun 3, 2026

What problem does this PR solve?

Issue Number: close #5191

What is changed and how it works?

Update Go version declarations and build instructions from 1.25.8 to 1.25.10 for release-8.5.

This PR updates:

  • root go.mod
  • tools/check/go.mod
  • tools/workload/go.mod
  • tests/integration_tests/debezium01/go.mod
  • deployments/integration-test.Dockerfile
  • deployments/next-gen-local-integration-test.Dockerfile
  • README Go installation instructions

No dependency versions are changed.

Check List

Tests

  • Manual test

Verified with:

GOMODCACHE=/private/tmp/go-mod-cache GOCACHE=/private/tmp/go-build-cache GOTOOLCHAIN=go1.25.10 go mod tidy
for d in tools/check tools/workload tests/integration_tests/debezium01; do (cd "$d" && GOMODCACHE=/private/tmp/go-mod-cache GOCACHE=/private/tmp/go-build-cache GOTOOLCHAIN=go1.25.10 go mod tidy); done
GOMODCACHE=/private/tmp/go-mod-cache GOCACHE=/private/tmp/go-build-cache GOTOOLCHAIN=go1.25.10 go list ./...
git diff --check

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

README Go installation instructions are updated.

Release note

None

@ti-chi-bot ti-chi-bot Bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Jun 3, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 3, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0622b567-107c-4d69-be66-9dcd8f05c5e9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 3, 2026
@pingcap-cla-assistant
Copy link
Copy Markdown

pingcap-cla-assistant Bot commented Jun 3, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go version from 1.25.8 to 1.25.10 across the repository, including go.mod files, Dockerfiles, and the README.md documentation. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@ti-chi-bot ti-chi-bot linked an issue Jun 3, 2026 that may be closed by this pull request
@lybcodes
Copy link
Copy Markdown
Author

lybcodes commented Jun 3, 2026

/hold

@ti-chi-bot ti-chi-bot Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 3, 2026
@lybcodes lybcodes force-pushed the chore/update-go-1.25.10-release-8.5 branch from c54d721 to 49188f2 Compare June 3, 2026 18:31
@ti-chi-bot ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 3, 2026
Signed-off-by: lyb <yebin.li@pingcap.com>
@ti-chi-bot ti-chi-bot Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 4, 2026
@lybcodes
Copy link
Copy Markdown
Author

lybcodes commented Jun 4, 2026

/unhold

@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 4, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlwilliamx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 4, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-06-04 10:20:45.454287492 +0000 UTC m=+436946.524604872: ☑️ agreed by wlwilliamx.

@ti-chi-bot ti-chi-bot Bot added the approved label Jun 4, 2026
@wlwilliamx
Copy link
Copy Markdown
Collaborator

/test all

@ti-chi-bot ti-chi-bot Bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Go to 1.25.10 for v8.5.7

2 participants