Skip to content

fix(ci): lock cargo-sort install#454

Merged
ti-chi-bot merged 1 commit into
pingcap:raftstore-proxyfrom
lybcodes:fix/pull-unit-test
May 6, 2026
Merged

fix(ci): lock cargo-sort install#454
ti-chi-bot merged 1 commit into
pingcap:raftstore-proxyfrom
lybcodes:fix/pull-unit-test

Conversation

@lybcodes
Copy link
Copy Markdown

@lybcodes lybcodes commented Apr 27, 2026

What is changed and how it works?

Issue Number: N/A (GitHub Issues disabled)

What's Changed:

The prowjob `pull-unit-test` in pingcap-qe/ci repo runs `make ci_fmt_check`, which installs `cargo-sort v1.0.9` during `pre-format`.

Although the `cargo-sort` version is pinned, the install command did not use `--locked`, so Cargo still resolved transitive dependencies from the latest crates.io index. A newer transitive dependency (`clap_lex v1.1.0`) now requires Rust 2024 edition support, which is not available in the CI Cargo version, causing the format check setup to fail before tests run.

This PR adds `--locked` to the `cargo-sort v1.0.9` install command so Cargo uses the dependency versions from the crate's lockfile.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note


@pingcap-cla-assistant
Copy link
Copy Markdown

pingcap-cla-assistant Bot commented Apr 27, 2026

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot Bot added the size/XS label Apr 27, 2026
Signed-off-by: lyb <yebin.li@pingcap.com>
@lybcodes lybcodes force-pushed the fix/pull-unit-test branch from fd6cccd to a34346a Compare April 27, 2026 09:24
@lybcodes
Copy link
Copy Markdown
Author

/hold

@lybcodes
Copy link
Copy Markdown
Author

/retest

@lybcodes
Copy link
Copy Markdown
Author

/test pull-unit-test

@lybcodes
Copy link
Copy Markdown
Author

/test pull-unit-test

@lybcodes lybcodes force-pushed the fix/pull-unit-test branch from bb34d49 to a34346a Compare April 28, 2026 07:12
@ti-chi-bot ti-chi-bot Bot added size/XS and removed size/M labels Apr 28, 2026
@lybcodes
Copy link
Copy Markdown
Author

Flaky Cases
shared::snapshot::test_basic_concurrent_snapshot
Symptom: Repeated failures occur in the shared::snapshot test suite.

@ti-chi-bot ti-chi-bot Bot added the lgtm label Apr 29, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 29, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-29 08:09:58.044852737 +0000 UTC m=+2758203.250212794: ☑️ agreed by CalvinNeo.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Apr 29, 2026
@CalvinNeo
Copy link
Copy Markdown
Member

/retest

@lybcodes
Copy link
Copy Markdown
Author

/unhold

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 29, 2026

@lybcodes: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test a34346a link true /test pull-unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lybcodes
Copy link
Copy Markdown
Author

lybcodes commented May 6, 2026

/override pull-unit-test

1 similar comment
@ti-chi-bot
Copy link
Copy Markdown
Member

/override pull-unit-test

@ti-chi-bot ti-chi-bot merged commit 4f5d4f8 into pingcap:raftstore-proxy May 6, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants