-
Notifications
You must be signed in to change notification settings - Fork 410
Closed
Labels
affects-6.0affects-6.1This bug affects the 6.1.x(LTS) versions.This bug affects the 6.1.x(LTS) versions.affects-6.2affects-6.3affects-6.4affects-6.5This bug affects the 6.5.x(LTS) versions.This bug affects the 6.5.x(LTS) versions.affects-6.6affects-7.0affects-7.1This bug affects the 7.1.x(LTS) versions.This bug affects the 7.1.x(LTS) versions.affects-7.2component/computeseverity/majortype/bugThe issue is confirmed as a bug.The issue is confirmed as a bug.
Description
Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
active_set_soft_limit is expected to limit the active query count even if thread_soft_limit is not reached.
For example, if active_set_soft_limit is set to 10, and currently, the there is 10 running queries, then any new comming query should not be scheduled except that the new comming query is a query with min_tso.
But in current implementation:
| auto check_for_not_min_tso = (active_set.size() < active_set_soft_limit || query_id <= *active_set.rbegin()) && (estimated_thread_usage + needed_threads <= thread_soft_limit); |
Even if
active_set_soft_limit is already reached, the schedule will still allow new task to running if the tso of current task is less than the max_tso in current active set(active_set.size() < active_set_soft_limit || query_id <= *active_set.rbegin()).
2. What did you expect to see? (Required)
3. What did you see instead (Required)
4. What is your TiFlash version? (Required)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
affects-6.0affects-6.1This bug affects the 6.1.x(LTS) versions.This bug affects the 6.1.x(LTS) versions.affects-6.2affects-6.3affects-6.4affects-6.5This bug affects the 6.5.x(LTS) versions.This bug affects the 6.5.x(LTS) versions.affects-6.6affects-7.0affects-7.1This bug affects the 7.1.x(LTS) versions.This bug affects the 7.1.x(LTS) versions.affects-7.2component/computeseverity/majortype/bugThe issue is confirmed as a bug.The issue is confirmed as a bug.