Storages: Fix the statistics of user_read_bytes and add metrics (#10396)#10404
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@JinheLin This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/hold testing |
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #10396
What problem does this PR solve?
Issue Number: ref #10380
ConcatSkippableBlockInputStreamDeltaMergeBlockInputStream. ThegetPlacedStreammethod sets theneed_row_idparameter to false when obtaining the stable stream. Therefore, in ConcatSkippableBlockInputStream,need_row_idcannot be used to determine whether MVCC is involved.DeltaValueReadergetInputStreamNormalto read data, delta data is read throughDeltaValueReader. Thus,DeltaValueReaderneeds to add statistics foruser_read_bytes.user_read_bytesand metrics withinScanContext.ReadTag::Internal.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note