Skip to content

disagg: Fix deployed on kingsoft ks3#10599

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
JaySon-Huang:fix_disagg_on_ks3
Dec 9, 2025
Merged

disagg: Fix deployed on kingsoft ks3#10599
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
JaySon-Huang:fix_disagg_on_ks3

Conversation

@JaySon-Huang
Copy link
Copy Markdown
Contributor

@JaySon-Huang JaySon-Huang commented Dec 9, 2025

What problem does this PR solve?

Issue Number: close #10598, ref #10569

Problem Summary:

What is changed and how it works?

* Support parsing kingsoft ks3 endpoint as `CloudVendor::KingsoftCloud`
* Improve the compatibility of deployed under unknown cloud vendor that need virtual addressing

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • Verified on internal testing env with kingsoft cloud ks3
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Dec 9, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for Kingsoft Cloud KS3 object storage and improves the logic for handling unknown cloud vendors with respect to virtual addressing requirements. The changes enable TiFlash to properly detect and configure Kingsoft Cloud endpoints while maintaining backward compatibility for other S3-compatible services.

Key changes:

  • Added KingsoftCloud vendor enum and renamed/reorganized Unknown vendor types to distinguish between services requiring virtual addressing (Unknown) and those not requiring it (UnknownFixAddress)
  • Updated endpoint parsing regex to recognize Kingsoft Cloud endpoint patterns (ks3--internal.ksyuncs.com and ks3-.ksyuncs.com)
  • Enhanced port-based logic to better determine when unknown vendors need virtual addressing (default ports) versus fixed addressing (custom ports)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
dbms/src/Storages/S3/S3Common.h Added KingsoftCloud enum value and split Unknown into UnknownFixAddress and Unknown to differentiate virtual addressing requirements
dbms/src/Storages/S3/S3Common.cpp Updated regex pattern to parse Kingsoft Cloud endpoints, refined vendor detection logic with port-based checks for unknown vendors
dbms/src/Storages/S3/Credentials.cpp Added credential provider handling for KingsoftCloud (falls through to AWS providers) and properly handles both Unknown variants
dbms/src/Storages/S3/tests/gtest_s3common.cpp Added comprehensive test cases for Kingsoft Cloud endpoints (internal/external) and expanded tests for unknown vendor scenarios with various port configurations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread dbms/src/Storages/S3/tests/gtest_s3common.cpp Outdated
@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 9, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Dec 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 9, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Dec 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-09 08:55:47.82876368 +0000 UTC m=+944892.642541252: ☑️ agreed by Lloyd-Pottiger.
  • 2025-12-09 12:05:19.64777463 +0000 UTC m=+956264.461552202: ☑️ agreed by JinheLin.

@ti-chi-bot ti-chi-bot Bot merged commit bf3a3db into pingcap:master Dec 9, 2025
7 checks passed
@JaySon-Huang JaySon-Huang deleted the fix_disagg_on_ks3 branch December 9, 2025 12:13
@JaySon-Huang
Copy link
Copy Markdown
Contributor Author

/cherry-pick release-nextgen-20251011

@ti-chi-bot
Copy link
Copy Markdown
Member

@JaySon-Huang: new pull request created to branch release-nextgen-20251011: #10600.

Details

In response to this:

/cherry-pick release-nextgen-20251011

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot Bot pushed a commit that referenced this pull request Dec 10, 2025
ref #10569, close #10598

* Support parsing kingsoft ks3 endpoint as `CloudVendor::KingsoftCloud`
* Improve the compatibility of deployed under unknown cloud vendor that need virtual addressing

Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: JaySon-Huang <tshent@qq.com>
Co-authored-by: JaySon <tshent@qq.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
wshwsh12 pushed a commit to wshwsh12/tiflash that referenced this pull request Feb 9, 2026
ref pingcap#10569, close pingcap#10598

* Support parsing kingsoft ks3 endpoint as `CloudVendor::KingsoftCloud`
* Improve the compatibility of deployed under unknown cloud vendor that need virtual addressing

Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Encountered Unknown AWSError 'SecondLevelDomainForbidden': The bucket you are attempting to access must be addressed using KS3 third level domain.

5 participants