Skip to content

Conversation

@JaySon-Huang
Copy link
Contributor

cherry-pick of #10609


What problem does this PR solve?

Issue Number: close #10605

Problem Summary: as the issue comment describe #10605 (comment)

KVStore::preHandleSSTsToDTFiles is the common path for both PreHandleSnapshot and IngestSST, calling prehandling_trace.waitForSubtaskResources will block the max concurrency of IngestSST by the pre handle snapshot thread-pool

What is changed and how it works?

* Parse `raftstore.apply-low-priority-pool-size` in `KVStore::fetchProxyConfig`
* `KVStore::getMaxPrehandleSubtaskSize` return different max concurrency according to the job_type

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    confirm that tiflash can successful parse and get the ingest sst max concurrency from tiflash-proxy
[2025/12/11 16:12:20.053 +08:00] [INFO] [KVStore.cpp:144] ["Parsed proxy config: snap_handle_pool_size=16 apply_low_priority_pool_size=72 engine_addr=10.2.12.81:9581"] [thread_id=1]

Run BR restore chbenchmark-1500

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix an issue where TiFlash could not fully utilize more than 16 CPU cores during BR restore

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 11, 2025
…y-pool-size

Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang JaySon-Huang force-pushed the fix_ingest_sst_concurrency_85 branch from f6cdb35 to f7c2eeb Compare December 11, 2025 09:43
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 11, 2025
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2025
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 11, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 12, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 12, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 12, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-12 02:40:32.075407357 +0000 UTC m=+1181576.889184929: ☑️ agreed by CalvinNeo.
  • 2025-12-12 02:45:14.170064804 +0000 UTC m=+1181858.983842375: ☑️ agreed by JinheLin.

@ti-chi-bot ti-chi-bot bot merged commit 3bd94e2 into pingcap:release-8.5 Dec 12, 2025
4 checks passed
@JaySon-Huang JaySon-Huang deleted the fix_ingest_sst_concurrency_85 branch December 12, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants