Skip to content

tici: consume columnar search results in tiflash#10802

Open
wshwsh12 wants to merge 4 commits intopingcap:feature/ftsfrom
wshwsh12:wsh/tiflash-columnar-search-result
Open

tici: consume columnar search results in tiflash#10802
wshwsh12 wants to merge 4 commits intopingcap:feature/ftsfrom
wshwsh12:wsh/tiflash-columnar-search-result

Conversation

@wshwsh12
Copy link
Copy Markdown
Contributor

@wshwsh12 wshwsh12 commented Apr 14, 2026

What problem does this PR solve?

Issue Number: N/A

Problem Summary:

Consume the new columnar TiCI search result format in TiFlash so Tantivy reads no longer need row-wise result materialization. This PR depends on pingcap-inc/tici#1195.

What is changed and how it works?

tici: consume columnar search results in tiflash

Simplify Tantivy nullable handling

Restore Tantivy formatting

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Manual test steps:

  • start a TiCI playground cluster with custom TiDB/TiKV/TiCDC/TiCI/TiFlash binaries
  • verify pure cop[tici] FTS queries and returned values for signed/unsigned integers, floats, datetime/timestamp, string, bytes, and nullable alternating rows
  • compare pure cop[tici] query latency before and after the columnar search result change

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 14, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign searise for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 14, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)
  • release-8.5
  • release-7.5
  • release-8.1

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 432650f2-70ae-418c-9456-58b571ed50f4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 14, 2026
@wshwsh12 wshwsh12 requested a review from JinheLin April 14, 2026 04:10
@wshwsh12
Copy link
Copy Markdown
Contributor Author

@ChangRui-Ryan @JinheLin PTAL

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 14, 2026

@wshwsh12: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-sanitizer-asan 9dd43f3 link false /test pull-sanitizer-asan
pull-sanitizer-tsan 9dd43f3 link false /test pull-sanitizer-tsan

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant