tici: consume columnar search results in tiflash#10802
tici: consume columnar search results in tiflash#10802wshwsh12 wants to merge 4 commits intopingcap:feature/ftsfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@ChangRui-Ryan @JinheLin PTAL |
|
@wshwsh12: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: N/A
Problem Summary:
Consume the new columnar TiCI search result format in TiFlash so Tantivy reads no longer need row-wise result materialization. This PR depends on pingcap-inc/tici#1195.
What is changed and how it works?
Check List
Tests
Manual test steps:
cop[tici]FTS queries and returned values for signed/unsigned integers, floats, datetime/timestamp, string, bytes, and nullable alternating rowscop[tici]query latency before and after the columnar search result changeSide effects
Documentation
Release note