Skip to content

metrics: improve getGCSafePointWithRetry metrics (#10807)#10812

Merged
CalvinNeo merged 1 commit intopingcap:release-fts-202602from
CalvinNeo:cp-202602
Apr 23, 2026
Merged

metrics: improve getGCSafePointWithRetry metrics (#10807)#10812
CalvinNeo merged 1 commit intopingcap:release-fts-202602from
CalvinNeo:cp-202602

Conversation

@CalvinNeo
Copy link
Copy Markdown
Member

close #10808

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?


Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

close pingcap#10808

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot Bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 23, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)
  • release-8.5
  • release-7.5
  • release-8.1

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ab176d38-c03a-431e-a828-4c5119bbaeba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 23, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 23, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin
Once this PR has been reviewed and has the lgtm label, please assign yudongusa for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 23, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Apr 23, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-23 07:50:44.905909944 +0000 UTC m=+2238650.111269991: ☑️ agreed by JinheLin.
  • 2026-04-23 07:50:52.337929511 +0000 UTC m=+2238657.543289568: ☑️ agreed by JaySon-Huang.

@CalvinNeo
Copy link
Copy Markdown
Member Author

/retest

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Apr 23, 2026

@CalvinNeo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-sanitizer-asan bf54099 link false /test pull-sanitizer-asan
pull-integration-test bf54099 link true /test pull-integration-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@CalvinNeo
Copy link
Copy Markdown
Member Author

/retest pull-integration-test

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Apr 23, 2026

@CalvinNeo: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test pull-integration-test
/test pull-unit-test

The following commands are available to trigger optional jobs:

/test pull-error-log-review
/test pull-sanitizer-asan
/test pull-sanitizer-tsan

Use /test all to run the following jobs that were automatically triggered:

pingcap/tiflash/pull_integration_test
pingcap/tiflash/pull_unit_test
pull-sanitizer-asan
pull-sanitizer-tsan
Details

In response to this:

/retest pull-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@CalvinNeo
Copy link
Copy Markdown
Member Author

/test pull-integration-test

@CalvinNeo CalvinNeo merged commit cbe33d1 into pingcap:release-fts-202602 Apr 23, 2026
3 of 7 checks passed
@CalvinNeo
Copy link
Copy Markdown
Member Author

img_v3_02111_369dea4a-0e1d-4a6d-a152-dea43ec9100g Note this branch has unhealthy version. So it can't success. Bypass it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants