Skip to content

Reduce/downgrade some MPPTask logs #10821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gengliqi wants to merge 2 commits into
base: master
Choose a base branch
from
+17 −7
Open

Reduce/downgrade some MPPTask logs #10821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89f9b94
reduce some logs
gengliqi Apr 24, 2026
cd281ae
u
gengliqi Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dbms/src/Flash/Mpp/MPPHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ grpc::Status MPPHandler::execute(const ContextPtr & context, mpp::DispatchTaskRe
#endif

task->run();
LOG_INFO(log, "processing dispatch is over; the time cost is {} ms", stopwatch.elapsedMilliseconds());
LOG_DEBUG(log, "processing dispatch is over; the time cost is {} ms", stopwatch.elapsedMilliseconds());
}
catch (Exception & e)
{
Expand Down
20 changes: 15 additions & 5 deletions dbms/src/Flash/Mpp/MPPTask.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ MPPTask::~MPPTask()
if (query_memory_tracker != nullptr && current_memory_tracker != query_memory_tracker)
current_memory_tracker = query_memory_tracker;
abortTunnels("", true);
LOG_INFO(log, "finish MPPTask: {}, total run time is {} ms", id.toString(), total_run_time_ms);
LOG_DEBUG(log, "finish MPPTask: {}", id.toString());
}

bool MPPTask::isRootMPPTask() const
Expand Down Expand Up @@ -452,11 +452,16 @@ void MPPTask::unregisterTask()
{
if (is_registered)
{
Stopwatch watch;
auto [result, reason] = manager->unregisterTask(id, getErrString());
auto elapsed_ms = watch.elapsedMilliseconds();
if (result)
LOG_DEBUG(log, "task unregistered");
{
auto log_level = elapsed_ms > 1000 ? Poco::Message::PRIO_INFORMATION : Poco::Message::PRIO_DEBUG;
LOG_IMPL(log, log_level, "task unregistered, time cost is {} ms", elapsed_ms);
}
else
LOG_WARNING(log, "task failed to unregister, reason: {}", reason);
LOG_WARNING(log, "task failed to unregister, time cost is {} ms, reason: {}", elapsed_ms, reason);
}
}

Expand Down Expand Up @@ -643,8 +648,12 @@ void MPPTask::runImpl()
auto time_cost_in_schedule_ns = stopwatch.elapsed() - time_cost_in_preprocess_ns;
dag_context->minTSO_wait_time_ns = time_cost_in_schedule_ns;
auto time_cost_in_schedule_ms = time_cost_in_schedule_ns / MILLISECOND_TO_NANO;
LOG_INFO(
auto time_cost_before_running_ms = time_cost_in_schedule_ms + time_cost_in_preprocess_ms;
auto log_level
= time_cost_before_running_ms > 1000 ? Poco::Message::PRIO_INFORMATION : Poco::Message::PRIO_DEBUG;
LOG_IMPL(
log,
log_level,
"task starts running, time cost in schedule: {} ms, time cost in preprocess: {} ms",
time_cost_in_schedule_ms,
time_cost_in_preprocess_ms);
Expand All @@ -671,7 +680,7 @@ void MPPTask::runImpl()

auto result = query_executor_holder->execute();

auto log_level = Poco::Message::PRIO_DEBUG;
log_level = Poco::Message::PRIO_DEBUG;
if (!result.is_success || status != RUNNING)
log_level = Poco::Message::PRIO_INFORMATION;
LOG_IMPL(
Expand Down Expand Up @@ -778,6 +787,7 @@ void MPPTask::runImpl()

total_run_time_ms = stopwatch.elapsedMilliseconds();
LOG_DEBUG(log, "task ends, time cost is {} ms.", total_run_time_ms);

unregisterTask();
}

Expand Down
2 changes: 1 addition & 1 deletion dbms/src/Flash/Pipeline/Schedule/Events/Event.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ void Event::onInputFinish()
if (0 == cur_value)
{
schedule();
LOG_INFO(log, "Event is scheduled");
LOG_DEBUG(log, "Event is scheduled");
}
}

Expand Down