Skip to content

Fix potential data loss for tombstoned table (#1010)#1661

Closed
ti-srebot wants to merge 1 commit intopingcap:release-3.1from
ti-srebot:release-3.1-7cfe93ddb714
Closed

Fix potential data loss for tombstoned table (#1010)#1661
ti-srebot wants to merge 1 commit intopingcap:release-3.1from
ti-srebot:release-3.1-7cfe93ddb714

Conversation

@ti-srebot
Copy link
Copy Markdown
Collaborator

@ti-srebot ti-srebot commented Mar 26, 2021

cherry-pick #1010 to release-3.1
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/1661

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/1661:release-3.1-7cfe93ddb714

What problem does this PR solve?

Issue Number: close #1007

Problem Summary:

What is changed and how it works?

What's Changed:

  • Do write the data into storage even if it is tombstoned.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn: none
  • Need to cherry-pick to the release branch: 4.0, 3.1.

Check List

Tests

  • Integration test

Side effects

  • None

Release note

  • Fix potential data loss when recovering a table that is previously dropped.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. labels Mar 26, 2021
@ti-srebot ti-srebot requested a review from JaySon-Huang March 26, 2021 14:43
@ti-srebot ti-srebot added this to the v3.1.3 milestone Mar 26, 2021
@JaySon-Huang
Copy link
Copy Markdown
Contributor

Close it because we don't maintain the branch release-3.1

@JaySon-Huang JaySon-Huang deleted the release-3.1-7cfe93ddb714 branch March 26, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants