Skip to content

Fix pre-decode illegal region snapshot data while using br/lighting#1692

Merged
solotzg merged 1 commit intopingcap:masterfrom
solotzg:fix-br-error
Mar 30, 2021
Merged

Fix pre-decode illegal region snapshot data while using br/lighting#1692
solotzg merged 1 commit intopingcap:masterfrom
solotzg:fix-br-error

Conversation

@solotzg
Copy link
Copy Markdown
Contributor

@solotzg solotzg commented Mar 30, 2021 •
edited
Loading

Signed-off-by: Zhigao Tong tongzhigao@pingcap.com

What problem does this PR solve?

Issue Number: close #1691

Problem Summary:

  • Br ingests sst files of write cf into tikv without default cf, tiflash paniced while pre-decode region snapshot data.

What is changed and how it works?

What's Changed:

  • Skip pre-decode and keep original cache. After sst files about default cf are ingested, committed data will be written into storage.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

  • Fix the issue that TiFlash may panic during br restore

@solotzg
Fix pre-decode illegal region snapshot data while using br/lighting
fd5227a 
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
@solotzg solotzg requested a review from JaySon-Huang March 30, 2021 07:31
JaySon-Huang
JaySon-Huang approved these changes Mar 30, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2021
@JaySon-Huang JaySon-Huang added needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 type/bugfix This PR fixes a bug. labels Mar 30, 2021
@JaySon-Huang
Copy link
Copy Markdown
Contributor

JaySon-Huang commented Mar 30, 2021

/run-all-tests

@solotzg solotzg merged commit 6e45d97 into pingcap:master Mar 30, 2021
@solotzg solotzg deleted the fix-br-error branch March 30, 2021 09:04
@ti-srebot ti-srebot mentioned this pull request Mar 30, 2021
Merged
@ti-srebot
Copy link
Copy Markdown
Collaborator

ti-srebot commented Mar 30, 2021

cherry pick to release-4.0 in PR #1697

@ti-srebot ti-srebot mentioned this pull request Mar 30, 2021
Merged
@ti-srebot
Copy link
Copy Markdown
Collaborator

ti-srebot commented Mar 30, 2021

cherry pick to release-5.0 in PR #1698

solotzg added a commit that referenced this pull request Apr 3, 2021
@ti-srebot @solotzg
cherry pick #1692 to release-4.0 (#1697)
80fdeee 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Zhigao Tong <tongzhigao@pingcap.com>
ti-srebot added a commit that referenced this pull request Apr 8, 2021
@ti-srebot
Fix pre-decode illegal region snapshot data while using br/lighting (#…
6c7d621 
…1692) (#1698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

No one assigned

Labels

needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TiFlash panic during br restore

3 participants

@solotzg @JaySon-Huang @ti-srebot