Storage: should seek before read

[Lloyd-Pottiger]

What problem does this PR solve?

Issue Number: close pingcap/tidb#42555

Problem Summary:

What is changed and how it works?

1. set partition_table_scan.pushed_down_filter_conditions
2. seek before read when skip last time
3. & with bitmap when filter condition is always true

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• JinheLin
• ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[Lloyd-Pottiger]

/run-all-tests

[JaySon-Huang]

Can we add tests to prevent it happen again?

[Lloyd-Pottiger]

Can we add tests to prevent it happen again?

will add in master, we should merge into 7.0 as soon as possible, so will not add ut in this pr.

[Lloyd-Pottiger]

/run-integration-test

[Lloyd-Pottiger]

[2023-03-25T05:56:50.399Z] tidb-ci/async_grpc/mpp_fail.test: Running
[2023-03-25T05:56:53.682Z]   File: tidb-ci/async_grpc/mpp_fail.test
[2023-03-25T05:56:53.682Z]   Error line: 35
[2023-03-25T05:56:53.682Z]   Error: DBGInvoke get_active_threads_in_dynamic_thread_pool()
[2023-03-25T05:56:53.682Z]   Result:
[2023-03-25T05:56:53.682Z]     ┌─get_active_threads_in_dynamic_thread_pool()─┐
[2023-03-25T05:56:53.682Z]     │ 1                                           │
[2023-03-25T05:56:53.682Z]     └─────────────────────────────────────────────┘
[2023-03-25T05:56:53.682Z]   Expected:
[2023-03-25T05:56:53.682Z]     ┌─get_active_threads_in_dynamic_thread_pool()─┐
[2023-03-25T05:56:53.682Z]     │ 0                                           │
[2023-03-25T05:56:53.682Z]     └─────────────────────────────────────────────┘

unstable test

[JinheLin]

Better to be another name since name filter is used before.

[Lloyd-Pottiger]

/merge

[ti-chi-bot]

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Details

Commit hash: 37c49b9

[Lloyd-Pottiger]

/run-integration-test