Skip to content

fix keep order in table scan is lost when remote read of PartitionTableScan(release-7.1)#7526

Merged
ti-chi-bot[bot] merged 11 commits intopingcap:release-7.1from
Lloyd-Pottiger:DNM
May 23, 2023
Merged

fix keep order in table scan is lost when remote read of PartitionTableScan(release-7.1)#7526
ti-chi-bot[bot] merged 11 commits intopingcap:release-7.1from
Lloyd-Pottiger:DNM

Conversation

@Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented May 22, 2023 •
edited by JaySon-Huang
Loading

Signed-off-by: Lloyd-Pottiger yan1579196623@gmail.com### What problem does this PR solve?

Issue Number: close #7519, close #7527

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Lloyd-Pottiger
fix
3ea2c82 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 22, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JinheLin
  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 22, 2023
@Lloyd-Pottiger
remove config
a84715d 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
add log
44dbe93 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
fix
21bec61 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger Lloyd-Pottiger changed the title DNM fix keep order in table scan is lost May 22, 2023
@Lloyd-Pottiger
refine
e13893a 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
Copy link
Contributor Author

Lloyd-Pottiger commented May 23, 2023

/cc @JinheLin @SeaRise

@ti-chi-bot ti-chi-bot bot requested review from JinheLin and SeaRise May 23, 2023 03:02
SeaRise
SeaRise approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs more investigation on master branch

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 23, 2023
JaySon-Huang
JaySon-Huang reviewed May 23, 2023
View reviewed changes
Lloyd-Pottiger and others added 2 commits May 23, 2023 14:51
@Lloyd-Pottiger @JaySon-Huang
Update dbms/src/Storages/DeltaMerge/DeltaMergeStore.cpp
e3cb9fb 
Co-authored-by: JaySon <tshent@qq.com>
@Lloyd-Pottiger
fix
df0a606 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 23, 2023
JaySon-Huang
JaySon-Huang reviewed May 23, 2023
View reviewed changes
@Lloyd-Pottiger
fix & add test
4cf65b8 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 23, 2023
@Lloyd-Pottiger
throw exception
b973652 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
useless line
12560d8 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
JaySon-Huang
JaySon-Huang approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lloyd-Pottiger Lloyd-Pottiger changed the title fix keep order in table scan is lost fix keep order in table scan is lost when remote read of PartitionTableScan May 23, 2023
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented May 23, 2023

/run-all-tests

@JaySon-Huang JaySon-Huang changed the title fix keep order in table scan is lost when remote read of PartitionTableScan fix keep order in table scan is lost when remote read of PartitionTableScan(release-7.1) May 23, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 23, 2023
@Lloyd-Pottiger
Copy link
Contributor Author

Lloyd-Pottiger commented May 23, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2023

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 12560d8

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 23, 2023
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented May 23, 2023

/rebuild

@ti-chi-bot ti-chi-bot bot merged commit cffc61e into pingcap:release-7.1 May 23, 2023
@Lloyd-Pottiger Lloyd-Pottiger mentioned this pull request May 23, 2023
Closed
12 tasks
@Lloyd-Pottiger Lloyd-Pottiger deleted the DNM branch May 23, 2023 13:19
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@JinheLin JinheLin JinheLin approved these changes

+1 more reviewer

@SeaRise SeaRise SeaRise approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Lloyd-Pottiger @JaySon-Huang @JinheLin @SeaRise @VelocityLight