Skip to content

Improve error message for tidb TableScan schema check#7637

Merged
ti-chi-bot[bot] merged 14 commits intopingcap:masterfrom
SeaRise:refine_schema_check
Jul 11, 2023
Merged

Improve error message for tidb TableScan schema check#7637
ti-chi-bot[bot] merged 14 commits intopingcap:masterfrom
SeaRise:refine_schema_check

Conversation

@SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Jun 12, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #6806

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Jun 12, 2023

/run-integration-test

@SeaRise SeaRise changed the title DNM Improve error message for tidb scan schema check Jun 12, 2023
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-linked-issue labels Jun 12, 2023
@SeaRise SeaRise changed the title Improve error message for tidb scan schema check DNM: Improve error message for tidb scan schema check Jun 12, 2023
@SeaRise SeaRise changed the title DNM: Improve error message for tidb scan schema check Improve error message for tidb scan schema check Jun 28, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Jun 28, 2023

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 11, 2023

/run-integration-test

@SeaRise SeaRise removed needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jul 11, 2023
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jul 11, 2023
@SeaRise SeaRise removed needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jul 11, 2023
@SeaRise SeaRise mentioned this pull request Jul 11, 2023
Closed
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Jul 11, 2023
JaySon-Huang
JaySon-Huang reviewed Jul 11, 2023
View reviewed changes
@SeaRise SeaRise requested a review from JaySon-Huang July 11, 2023 06:19
JaySon-Huang
JaySon-Huang approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 11, 2023
SeaRise and others added 4 commits July 11, 2023 14:39
xzhangxian1008
xzhangxian1008 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 11, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 11, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-11 06:33:34.5592856 +0000 UTC m=+400106.329624297: ☑️ agreed by JaySon-Huang.
  • 2023-07-11 07:40:31.728370411 +0000 UTC m=+404123.498709121: ☑️ agreed by xzhangxian1008.

@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 11, 2023

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 11, 2023

/run-integration-test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 11, 2023

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 11, 2023

/run-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 54fb7c1 into pingcap:master Jul 11, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 11, 2023

In response to a cherrypick label: new pull request created to branch release-6.5: #7792.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jul 11, 2023
@SeaRise @ti-chi-bot
This is an automated cherry-pick of pingcap#7637
7c563a2 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 11, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 11, 2023

In response to a cherrypick label: new pull request created to branch release-7.1: #7793.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 11, 2023
Closed
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jul 11, 2023
@SeaRise @ti-chi-bot
This is an automated cherry-pick of pingcap#7637
a38baa1 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@SeaRise SeaRise deleted the refine_schema_check branch July 26, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Awaiting requested review from Lloyd-Pottiger

+1 more reviewer

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Schema check failed for Int64 with Int32

4 participants

@SeaRise @ti-chi-bot @JaySon-Huang @xzhangxian1008