Reset current_memory_tracker when WNEstablishDisaggTaskHandler finished. (#8174)#8175
Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-7.4from Oct 10, 2023
Conversation
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
release-note-none
ti-chi-bot
added
size/XS
12 tasks
Contributor
|
/run-all-tests |
JinheLin
approved these changes
Oct 10, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
added
the
cherry-pick-approved
guo-shaoge
pushed a commit
to guo-shaoge/tiflash
that referenced
this pull request
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8174
What problem does this PR solve?
Issue Number: close #8173
Problem Summary:
In
WNEstablishDisaggTaskHandler::execute, aProcessListElementobject will be created and setscurrent_memory_trackerto itsmemory_trackermember in constructor. Andcurrent_memory_trackerwill be reset in the destructor ofProcessListElement.However, objects of
ProcessListElementare created in threads ofWNEstablishDisaggTaskPool, but destructed in threads of GRPC because it will be destructed with object ofWNEstablishDisaggTaskHandler(handler->dag_context->process_list_entry).This result in
current_memory_trackerof threads ofWNEstablishDisaggTaskPoolis not reset after task finished and other tasks may continue to use this memory tracker, although it may have already been destructed.What is changed and how it works?
current_memory_trackerafter tasks ofWNEstablishDisaggTaskPoolfinished.Check List
Tests
Side effects
Documentation
Release note