Revert "Refine cancel for read thread stream (#8511)"#8541
Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom Dec 18, 2023
Merged
Revert "Refine cancel for read thread stream (#8511)"#8541ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
Conversation
This reverts commit adf8569.
ti-chi-bot
bot
added
release-note-none
ti-chi-bot
bot
added
the
size/S
SeaRise
approved these changes
Dec 18, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
JinheLin
approved these changes
Dec 18, 2023
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, SeaRise The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Contributor
Author
|
/run-all-tests |
gengliqi
added
needs-cherry-pick-release-6.5
Member
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Dec 18, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Dec 18, 2023
Member
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Dec 18, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Member
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Dec 18, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Dec 18, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit adf8569.
What problem does this PR solve?
Issue Number: close #8539
Problem Summary:
See #8539
What is changed and how it works?
#8511 introduced an issue that
WorkQueue<Block>inSegmentReadTaskPoolmay not finish forever. Revert this PR to fix this issue for safety and simplicity.Check List
Tests
Side effects
Documentation
Release note