Skip to content

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 30, 2024

This is an automated cherry-pick of #8694

What problem does this PR solve?

Issue Number: close #9389

Problem Summary: printing the strerrno may cause data race under the new CI pipeline

      0x1141614e	StackTrace::StackTrace() [gtests_dbms+289497422]
       0x7e6baa4	fault_signal_handler(int) [gtests_dbms+132561572]
  0x7f054334c400	<unknown symbol> [libc.so.6+222208]
  0x7f054334f2bd	getenv [libc.so.6+234173]
  0x7f0543346e2e	__dcigettext [libc.so.6+200238]
  0x7f05433a2cde	strerror_r [libc.so.6+576734]
       0xdf52693	DB::DM::SegmentReader::setCPUAffinity() [gtests_dbms+234170003]
       0xdf52329	DB::DM::SegmentReader::run() [gtests_dbms+234169129]
       0xdf55de9	decltype(*(static_cast<DB::DM::SegmentReader*>(fp0)).*fp()) std::__1::__invoke<void (DB::DM::SegmentReader::*)(), DB::DM::SegmentReader*, void>(void (DB::DM::SegmentReader::*&&)(), DB::DM::SegmentReader*&&) [gtests_dbms+234184169]
       0xdf55d6e	void std::__1::__thread_execute<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (DB::DM::SegmentReader::*)(), DB::DM::SegmentReader*, 2ul>(std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (DB::DM::SegmentReader::*)(), DB::DM::SegmentReader*>&, std::__1::__tuple_indices<2ul>) [gtests_dbms+234184046]
       0xdf55a82	void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (DB::DM::SegmentReader::*)(), DB::DM::SegmentReader*> >(void*) [gtests_dbms+234183298]
  0x7f0543901ea5	start_thread [libpthread.so.0+32421]
  0x7f0543414b0d	clone [libc.so.6+1043213]

What is changed and how it works?

Only print the errno instead of its string

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Aug 30, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 30, 2024
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 30, 2024
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 30, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 30, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 30, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-30 03:16:41.325454104 +0000 UTC m=+1099396.459904226: ☑️ agreed by CalvinNeo.
  • 2024-08-30 03:17:15.671937121 +0000 UTC m=+1099430.806387237: ☑️ agreed by JinheLin.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 30, 2024
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@Lloyd-Pottiger
Copy link
Contributor

/run-integration-test

1 similar comment
@JaySon-Huang
Copy link
Contributor

/run-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 4eb0955 into pingcap:release-7.5 Aug 30, 2024
JaySon-Huang pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jan 29, 2026
… SegmentReader bind fail (pingcap#8694) (pingcap#9388)

close pingcap#9389

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

Co-authored-by: jinhelin <linjinhe33@gmail.com>
Co-authored-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants