Skip to content

disable some json functions pushdown #9447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 3 commits into from
Sep 21, 2024
Merged

disable some json functions pushdown #9447

ti-chi-bot merged 3 commits into from
Sep 21, 2024

Conversation

@windtalker
Copy link
Contributor

@windtalker windtalker commented Sep 20, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9444

Problem Summary:

Json comparision is not supported in TiFlash, this pr disable them.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@windtalker
save work
a5c3592 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2024
xzhangxian1008
xzhangxian1008 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 20, 2024
yibin87
yibin87 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 20, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-20 07:04:54.603880321 +0000 UTC m=+1203964.344304260: ☑️ agreed by xzhangxian1008.
  • 2024-09-20 07:09:49.216700966 +0000 UTC m=+1204258.957124905: ☑️ agreed by yibin87.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, xzhangxian1008, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 5935a1f into pingcap:master Sep 21, 2024
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Sep 23, 2024
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 23, 2024

In response to a cherrypick label: new pull request created to branch release-8.1: #9462.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 23, 2024
@windtalker @ti-chi-bot
This is an automated cherry-pick of pingcap#9447
c7a7053 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 23, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 23, 2024

In response to a cherrypick label: new pull request created to branch release-7.5: #9463.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 23, 2024
@windtalker @ti-chi-bot
This is an automated cherry-pick of pingcap#9447
2925cfb 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 23, 2024
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 23, 2024
@windtalker @ti-chi-bot
This is an automated cherry-pick of pingcap#9447
b658311 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 23, 2024

In response to a cherrypick label: new pull request created to branch release-7.1: #9464.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 23, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Sep 24, 2024
@ti-chi-bot @windtalker
disable some json functions pushdown (#9447) (#9463)
fc01c85 
close #9444

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: xufei <xufei@pingcap.com>
ti-chi-bot bot added a commit that referenced this pull request Sep 24, 2024
@ti-chi-bot @windtalker @ti-chi-bot
disable some json functions pushdown (#9447) (#9464)
0ad1189 
close #9444

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: xufei <xufei@pingcap.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this pull request Sep 27, 2024
@ti-chi-bot @windtalker
disable some json functions pushdown (#9447) (#9462)
aa9c596 
close #9444

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: xufei <xufei@pingcap.com>
@windtalker windtalker deleted the disable_some_json_functions branch December 6, 2024 00:10
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Jan 24, 2025
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 24, 2025

In response to a cherrypick label: new pull request created to branch release-6.5: #9831.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jan 24, 2025
@windtalker @ti-chi-bot
This is an automated cherry-pick of pingcap#9447
350979b 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 24, 2025
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 24, 2025

In response to a cherrypick label: new pull request created to branch release-6.1: #9832.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jan 24, 2025
@windtalker @ti-chi-bot
This is an automated cherry-pick of pingcap#9447
5821d94 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 24, 2025
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jan 26, 2025
@ti-chi-bot @windtalker
disable some json functions pushdown (#9447) (#9831)
bbc6bf0 
close #9444

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: xufei <xufei@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request Jan 26, 2025
@ti-chi-bot @windtalker
disable some json functions pushdown (#9447) (#9832)
9966e45 
close #9444

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: xufei <xufei@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yibin87 yibin87 yibin87 approved these changes

+2 more reviewers

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

@SeaRise SeaRise SeaRise approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

json compare related function is still not supported in TiFlash, TiDB should not pushdown these functions.

5 participants

@windtalker @ti-chi-bot @yibin87 @xzhangxian1008 @SeaRise