Storages: Skip filtering for filter column (#9361)

[ti-chi-bot]

This is an automated cherry-pick of #9361

What problem does this PR solve?

Issue Number: close #9348, ref #9103

Problem Summary:

If Min-Max index returns RSResult::All, we will create a EMPTY filter column to make some checks on block structure happy.

tiflash/dbms/src/DataStreams/FilterTransformAction.cpp

Lines 77 to 85 in f0a4087

	if (block.getRSResult().allMatch())
	{
	block.insert(
	filter_column,
	header.safeGetByPosition(filter_column)); // Make some checks on block structure happy.
	if (return_filter)
	res_filter = nullptr;
	return true;
	}

In LateMaterializationBlockInputStream, filter_column_stream does not execute projecting to remove filter column, and will execute filtering in

tiflash/dbms/src/Storages/DeltaMerge/LateMaterializationBlockInputStream.cpp

Lines 72 to 75 in f0a4087

	for (auto & col : filter_column_block)
	{
	col.column = col.column->filter(col_filter, passed_count);
	}

This result issue #9348.

What is changed and how it works?

Skip filtering for filter column as

tiflash/dbms/src/Storages/DeltaMerge/LateMaterializationBlockInputStream.cpp

Lines 113 to 117 in f0a4087

	for (auto & col : filter_column_block)
	{
	if (col.name == filter_column_name)
	continue;
	col.column = col.column->filter(*filter, passed_count);

Add add unit-test for this case.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hongyunyan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

1. It must be approved by the approvers firstly.
2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot]

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-unit-test	3d2f0a1	link	true	/test pull-unit-test
pull-integration-test	3d2f0a1	link	true	/test pull-integration-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.