cdc(logging): remove some verbose and useless logs#12604
cdc(logging): remove some verbose and useless logs#12604ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
Conversation
ti-chi-bot
Bot
added
do-not-merge/needs-linked-issue
release-note-none
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request focuses on reducing log verbosity and overhead by removing several log statements and unused imports across multiple modules, including the shared client, transport, and sink components. Key changes include increasing the slow region check interval from 30 seconds to 5 minutes and removing detailed lock resolution logging. Feedback indicates that the increased check interval may negatively impact observability and create logic inconsistencies. Additionally, the removal of logging in the lock resolver has left the totalLocks variable redundant, which should be cleaned up to avoid unnecessary memory and CPU overhead.
ti-chi-bot
Bot
added
needs-1-more-lgtm
ti-chi-bot
Bot
removed
do-not-merge/needs-linked-issue
do-not-merge/needs-triage-completed
labels
ti-chi-bot
Bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (53.4236%) is below the target coverage (60.0000%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #12604 +/- ##
================================================
- Coverage 53.5155% 53.4236% -0.0919%
================================================
Files 1037 1011 -26
Lines 145625 139981 -5644
================================================
- Hits 77932 74783 -3149
+ Misses 61845 59575 -2270
+ Partials 5848 5623 -225 🚀 New features to boost your workflow:
|
|
/retest |
9 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
/test pull-dm-integration-test |
|
/retest |
|
@3AceShowHand: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test pull-dm-integration-test |
|
@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, flowbehappy, wk989898 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-error-log-review |
5 participants
What problem does this PR solve?
Issue Number: close #11948
What is changed and how it works?
This is a sub PR of the #12591
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note