Skip to content

Remove unused function#17

Merged
suzaku merged 1 commit into
pingcap:masterfrom
suzaku:test-mysql
Sep 17, 2019
Merged

Remove unused function#17
suzaku merged 1 commit into
pingcap:masterfrom
suzaku:test-mysql

Conversation

@suzaku
Copy link
Copy Markdown
Contributor

@suzaku suzaku commented Sep 17, 2019

No description provided.

Comment thread cdc/schema.go Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and then remove this job ins.jobs?

Copy link
Copy Markdown
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suzaku suzaku merged commit c8ab7a1 into pingcap:master Sep 17, 2019
@suzaku suzaku deleted the test-mysql branch September 17, 2019 06:58
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
amyangfei pushed a commit to amyangfei/tiflow that referenced this pull request May 6, 2022
This PR

* Set timeout for every rpc request, including heartbeat.
* The master's ttl should be executors ttl + rpc timeout
* The master has a init ttl before the first heartbeat arrive.
* We shouldn't send tasks to executor before it sends the first heartbeat.
* refine the config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants