Skip to content

Copy schema from drainer#5

Merged
zier-one merged 1 commit intopingcap:masterfrom
zier-one:schema
Sep 9, 2019
Merged

Copy schema from drainer#5
zier-one merged 1 commit intopingcap:masterfrom
zier-one:schema

Conversation

@zier-one
Copy link
Contributor

@zier-one zier-one commented Sep 9, 2019

I just copy drainer/schema.go to here.

@zier-one zier-one requested a review from suzaku September 9, 2019 08:37
Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one merged commit a4307a5 into pingcap:master Sep 9, 2019
@zier-one zier-one deleted the schema branch September 9, 2019 08:43
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
amyangfei referenced this pull request in amyangfei/tiflow May 6, 2022
[master]: add packages and tools and define basic structure for master
joechenrh added a commit to joechenrh/tiflow that referenced this pull request Mar 18, 2026
…gcap#5)

1. Restore nil-guard on LoadChunk result to prevent panic when
   checkpoint file contains no chunk info.
2. Extract ChecksumCapableSource sub-interface from Source to avoid
   widening the core interface with checksum-only methods. Remove
   dead PreferGlobalChecksum/GetChecksumOnlyIterator from MySQLSources.
3. Rename PreferGlobalChecksum to type-assertion based capability check
   via ChecksumCapableSource, removing the misleading "Prefer" naming.
4. Add log.Warn before break in equalByGlobalChecksum error path so
   operators can see why remaining tables were skipped.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
joechenrh added a commit to joechenrh/tiflow that referenced this pull request Mar 18, 2026
…gcap#5)

1. Restore nil-guard on LoadChunk result to prevent panic when
   checkpoint file contains no chunk info.
2. Extract ChecksumCapableSource sub-interface from Source to avoid
   widening the core interface with checksum-only methods. Remove
   dead PreferGlobalChecksum/GetChecksumOnlyIterator from MySQLSources.
3. Rename PreferGlobalChecksum to type-assertion based capability check
   via ChecksumCapableSource, removing the misleading "Prefer" naming.
4. Add log.Warn before break in equalByGlobalChecksum error path so
   operators can see why remaining tables were skipped.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants