Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

Comments

tool: add revive#164

Merged
fewdan merged 2 commits intopingcap:masterfrom
mahjonp:lint
Apr 1, 2020
Merged

tool: add revive#164
fewdan merged 2 commits intopingcap:masterfrom
mahjonp:lint

Conversation

@mahjonp
Copy link
Contributor

@mahjonp mahjonp commented Apr 1, 2020

Signed-off-by: mahjonp junpeng.man@gmail.com

What problem does this PR solve?

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: mahjonp <junpeng.man@gmail.com>
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: mahjonp <junpeng.man@gmail.com>
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fewdan fewdan merged commit 95c00d2 into pingcap:master Apr 1, 2020
@mahjonp mahjonp deleted the lint branch April 1, 2020 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants