Skip to content

Support filtering users in the replayer#1157

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:mainfrom
djshow832:user
May 25, 2026
Merged

Support filtering users in the replayer#1157
ti-chi-bot[bot] merged 2 commits into
pingcap:mainfrom
djshow832:user

Conversation

@djshow832
Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: close #1156

Problem Summary:
Support filtering users in the replayer.

What is changed and how it works:
replayer --user-allowlist="u1,u2" ...

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 23, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot requested review from YangKeao and bb7133 May 23, 2026 12:22
@djshow832 djshow832 marked this pull request as ready for review May 23, 2026 12:22
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.00000% with 9 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@44711cc). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/sqlreplay/cmd/audit_log_plugin.go 80.00% 3 Missing and 1 partial ⚠️
pkg/sqlreplay/replay/replay.go 0.00% 2 Missing and 1 partial ⚠️
cmd/replayer/main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1157   +/-   ##
=======================================
  Coverage        ?   67.44%           
=======================================
  Files           ?      149           
  Lines           ?    16389           
  Branches        ?        0           
=======================================
  Hits            ?    11054           
  Misses          ?     4590           
  Partials        ?      745           
Flag Coverage Δ
unit 67.44% <70.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the lgtm label May 25, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 25, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-05-25 06:49:06.28492217 +0000 UTC m=+248416.255087232: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot Bot added the approved label May 25, 2026
@ti-chi-bot ti-chi-bot Bot merged commit 8306850 into pingcap:main May 25, 2026
6 checks passed
@djshow832 djshow832 deleted the user branch May 25, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support filtering users in the replayer

3 participants