balance: lower the OOM risk level during TiDB bootstrap#1167
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1167 +/- ##
=======================================
Coverage ? 67.60%
=======================================
Files ? 150
Lines ? 16661
Branches ? 0
=======================================
Hits ? 11264
Misses ? 4636
Partials ? 761
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/cherry-pick release-1.3 |
|
@djshow832: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/cherry-pick release-nextgen-202603 |
|
@djshow832: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #848
Problem Summary:
When TiDB starts, the memory usually increases sharply, leading to fake OOM risk. This will cause unnecessary session migrations.
What is changed and how it works:
Adjust the
TimeToOOMtotimeToOOM = time.Duration(float64(timeToOOM) / latestUsage * 0.6)./latestUsage: the lower the current usage is, the longer the timeToOOM is* 0.6: lower thetimeToOOMso that the thresholds don't need to be changedCheck List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.