Skip to content

Conversation

@djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #719

Problem Summary:
Support the compress option to traffic capture because compression makes CPU jitter.

What is changed and how it works:

  • Add compress option to tiproxyctl and HTTP API
  • Pass compress to rotateWriter

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

- Add `compress` option to traffic capture

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox November 21, 2024 08:11
@ti-chi-bot ti-chi-bot bot added the size/L label Nov 21, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@451e530). Learn more about missing BASE report.

Files with missing lines Patch % Lines
lib/cli/traffic.go 0.00% 7 Missing ⚠️
pkg/server/api/traffic.go 55.55% 3 Missing and 1 partial ⚠️
pkg/sqlreplay/capture/capture.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #720   +/-   ##
=======================================
  Coverage        ?   66.26%           
=======================================
  Files           ?      124           
  Lines           ?    11375           
  Branches        ?        0           
=======================================
  Hits            ?     7538           
  Misses          ?     3295           
  Partials        ?      542           
Flag Coverage Δ
unit 66.26% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-21 09:12:23.62891395 +0000 UTC m=+109331.248568466: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit 052bed0 into pingcap:main Nov 21, 2024
5 checks passed
@djshow832 djshow832 deleted the compress branch November 21, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support compression options

3 participants